Review main Merged

58078[TASK] Ensure ?id= is allowed to be called in site handling

Benni Mack CR +2 V +2 Hard +224 −191 updated 08/30/18, 21:43

Commit message

When using site configurations, it should still be possible to call a
page with "index.php?id=13" IF the site configuration's base is valid.

Currently, this was only possible when a language parameter was also
given, which vanished now.

Review

  • Code review CR +2
    • Susi Moog +2
    • Oliver Hader +1
  • Verified V +2
    • Susi Moog +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1628

Show 23 earlier messages
  1. Benni Mack uploaded patch set 1 08/30/18, 06:13

  2. Björn Jacob commented on patch set 1 08/30/18, 06:19

    "since there is"
  3. TYPO3com voted on patch set 1 V -1 08/30/18, 06:22 Completed build in 08m 46s on Thu, 30 Aug, 08:22 AM Test Summary: 72 of 35553 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27273

  1. Benni Mack uploaded patch set 2 08/30/18, 06:40

  2. Benni Mack updated the commit message in patch set 3 08/30/18, 06:42

  3. TYPO3com voted on patch set 2 V +1 08/30/18, 06:50 Completed build in 09m 52s on Thu, 30 Aug, 08:50 AM Test Summary: 35319 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27275

  4. TYPO3com voted on patch set 3 V +1 08/30/18, 06:52 Completed build in 09m 46s on Thu, 30 Aug, 08:52 AM Test Summary: 35319 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27276

  5. Benni Mack uploaded patch set 4 08/30/18, 18:21

  6. TYPO3com voted on patch set 4 V -1 08/30/18, 18:33 Completed build in 11m 56s on Thu, 30 Aug, 08:33 PM Test Summary: 503 of 35610 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27346

  7. Oliver Hader uploaded patch set 5 08/30/18, 19:49

  8. TYPO3com voted on patch set 5 V -1 08/30/18, 19:58 Completed build in 08m 25s on Thu, 30 Aug, 09:58 PM Test Summary: 463 of 35610 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27351

  9. Oliver Hader uploaded patch set 6 08/30/18, 20:07

  10. TYPO3com voted on patch set 6 V -1 08/30/18, 20:16 Completed build in 09m 03s on Thu, 30 Aug, 10:16 PM Test Summary: 447 of 35610 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27354

  11. Oliver Hader uploaded patch set 7 08/30/18, 20:28

  12. TYPO3com voted on patch set 7 V -1 08/30/18, 20:36 Completed build in 08m 05s on Thu, 30 Aug, 10:36 PM Test Summary: 393 of 35556 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27357

  13. Oliver Hader uploaded patch set 8 08/30/18, 20:47

  14. TYPO3com voted on patch set 8 V -1 08/30/18, 20:56 Completed build in 08m 44s on Thu, 30 Aug, 10:56 PM Test Summary: 420 of 35556 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27358

  15. Oliver Hader uploaded patch set 9 08/30/18, 20:56

  16. TYPO3com voted on patch set 9 V -1 08/30/18, 21:06 Completed build in 09m 07s on Thu, 30 Aug, 11:06 PM Test Summary: 393 of 35556 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27362

  17. Oliver Hader uploaded patch set 10 08/30/18, 21:23

  18. TYPO3com voted on patch set 10 V -1 08/30/18, 21:24 Completed build in 09s on Thu, 30 Aug, 11:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27365

  19. Oliver Hader uploaded patch set 11 08/30/18, 21:24

  20. Oliver Hader uploaded patch set 12 08/30/18, 21:34

  21. TYPO3com voted on patch set 11 V -1 08/30/18, 21:36 Completed build in 11m 14s on Thu, 30 Aug, 11:36 PM Test Summary: 48 of 35556 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27367

  22. Oliver Hader voted on patch set 12 V +1 CR +1 08/30/18, 21:42

  23. TYPO3com voted on patch set 12 V +1 08/30/18, 21:43 Completed build in 08m 56s on Thu, 30 Aug, 11:43 PM Test Summary: 35322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27369

  24. Susi Moog voted on patch set 12 V +2 CR +2 08/30/18, 21:43

  25. Susi Moog merged patch set 13 08/30/18, 21:43