58082[BUGFIX] Show url segment for new pages
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Benni Mack +1
-
Verified V +2
- Susi Moog +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 2
Files 3
Review log 1825
-
Christian Kuhn uploaded patch set 1 08/30/18, 09:59
-
Christian Kuhn uploaded patch set 2 08/30/18, 10:02
-
TYPO3com voted on patch set 1 V -1 08/30/18, 10:10 Completed build in 10m 46s on Thu, 30 Aug, 12:10 PM Test Summary: 15 of 35553 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27290
-
TYPO3com voted on patch set 2 V -1 08/30/18, 10:14 Completed build in 09m 58s on Thu, 30 Aug, 12:14 PM Test Summary: 15 of 35553 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27292
-
Christian Kuhn uploaded patch set 3 08/30/18, 10:32
-
TYPO3com voted on patch set 3 V +1 08/30/18, 10:41 Completed build in 08m 55s on Thu, 30 Aug, 12:41 PM Test Summary: 35319 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27293
-
Wouter Wolters updated the commit message in patch set 4 08/30/18, 11:09
-
TYPO3com voted on patch set 4 V +1 08/30/18, 11:17 Completed build in 08m 08s on Thu, 30 Aug, 01:17 PM Test Summary: 35319 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27295
-
Oliver Hader commented on patch set 4 08/30/18, 11:50
-
Christian Kuhn commented on patch set 4 08/30/18, 11:57
PagesVisibleFieldsTest.php:51Replyalias field is shown for PseudoSite's. -
Benni Mack commented on patch set 4 V -1 08/30/18, 13:12
does not work for me. Create a newsubpage on a pagetree without site configuration shows a slug field. -
Christian Kuhn commented on patch set 4 08/30/18, 13:25
args. PseudoSite extends NullSite ... foo -
Christian Kuhn uploaded patch set 5 08/30/18, 13:27
-
TYPO3com voted on patch set 5 V +1 08/30/18, 13:36 Completed build in 08m 51s on Thu, 30 Aug, 03:36 PM Test Summary: 35334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27308
-
Andreas Kienast commented on patch set 5 08/30/18, 13:38
PseudoSiteTcaDisplayCondition.php:80This reads a bit clumsy. Is `get_class($site) === NullSite::class` a better alternative? -
Benni Mack commented on patch set 5 08/30/18, 13:43
PseudoSiteTcaDisplayCondition.php:80Reply Unresolvedif (!($site instanceof PseudoSite)) should be sufficient - we use that in lots of other places already. -
Benni Mack uploaded patch set 6 08/30/18, 15:08
-
Benni Mack voted on patch set 6 V +1 CR +1 08/30/18, 15:09
-
TYPO3com voted on patch set 6 V +1 08/30/18, 15:19 Completed build in 09m 53s on Thu, 30 Aug, 05:19 PM Test Summary: 35388 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27321
-
Susi Moog commented on patch set 6 CR -1 08/30/18, 15:47
PseudoSiteTcaDisplayCondition.php:19is NullSite used (besides the word in a comment?)PseudoSiteTcaDisplayCondition.php:66missing "is" -
Benni Mack uploaded patch set 7 08/30/18, 15:50
-
Benni Mack voted on patch set 7 V +1 CR +1 08/30/18, 15:57
-
TYPO3com voted on patch set 7 V +1 08/30/18, 15:59 Completed build in 09m 06s on Thu, 30 Aug, 05:59 PM Test Summary: 35388 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27324
-
Susi Moog voted on patch set 7 V +2 CR +2 08/30/18, 16:08
-
Susi Moog merged patch set 8 08/30/18, 16:08
PagesVisibleFieldsTest.php:51