Review main Merged

58084[TASK] Detect page routes based on deleted+workspace restriction

Benni Mack CR +2 V +2 Easy +6 −2 updated 08/30/18, 17:04

Commit message

The Page Router checks for all pages that are available by using
the FrontendRestrictionContainer for database queries.

This leads to side-effects in the future.

Instead, - because all page slugs in one site are unique per
language+workspace - the Page Router should only check
for deleted+current workspace, not wondering about any other
restriction, as this is done when all pages in the rootline are
checked later-on anyway.

This way, frontend previews should be available again.

Review

  • Code review CR +2
    • Susi Moog +2
    • Wouter Wolters +1
    • Daniel Sattler +1
  • Verified V +2
    • Susi Moog +2
    • Daniel Sattler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 08/30/18, 11:35

  2. TYPO3com voted on patch set 1 V +1 08/30/18, 11:43 Completed build in 07m 44s on Thu, 30 Aug, 01:43 PM Test Summary: 35319 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27296

  3. Daniel Sattler voted on patch set 1 V +1 CR +1 08/30/18, 17:03

  4. Wouter Wolters voted on patch set 1 CR +1 08/30/18, 17:03

  5. Susi Moog voted on patch set 1 V +2 CR +2 08/30/18, 17:04

  6. Susi Moog merged patch set 2 08/30/18, 17:04