Review main Merged

58087[TASK] Use $tsfe->type for generating the redirect URL

Benni Mack CR +2 V +2 Easy +5 −8 updated 08/30/18, 17:14

Commit message

At the point where TSFE creates a Redirect URL for shortcuts,
$type should be used from the normalized $tsfe->type property
and not from the GET variable directly, as this could have been modified
by a hook already.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Wouter Wolters +1
    • Daniel Sattler +1
  • Verified V +2
    • Susi Moog +2
    • Oliver Hader +1

Issues 1

Files 1

Review log 1012

  1. Benni Mack uploaded patch set 1 08/30/18, 13:22

  2. TYPO3com voted on patch set 1 V +1 08/30/18, 13:31 Completed build in 08m 45s on Thu, 30 Aug, 03:31 PM Test Summary: 35334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27307

  3. Oliver Hader voted on patch set 1 CR +1 08/30/18, 14:14

  4. Oliver Hader rebased onto patch set 2 08/30/18, 17:01

  5. Oliver Hader voted on patch set 2 CR +1 08/30/18, 17:02

  6. Wouter Wolters voted on patch set 2 CR +1 08/30/18, 17:04

  7. Daniel Sattler voted on patch set 2 CR +1 08/30/18, 17:04

  8. Oliver Hader voted on patch set 2 V +1 08/30/18, 17:05

  9. Oliver Hader voted on patch set 2 CR +2 08/30/18, 17:08

  10. Susi Moog voted on patch set 2 V +2 08/30/18, 17:09

  11. Oliver Hader merged patch set 3 08/30/18, 17:09

  12. TYPO3com voted on patch set 2 V +1 08/30/18, 17:14 Completed build in 12m 45s on Thu, 30 Aug, 07:14 PM Test Summary: 35367 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27333