Review main Merged

58089[BUGFIX] Remove check for switching URL schemes

Benni Mack CR +2 V +2 Easy +2 −5 updated 08/30/18, 14:09

Commit message

During the cleanup of https://review.typo3.org/#/c/58022/ a wrong
change was done, this actually introduces a regression showing that
the scheme part is never evaluated, removing the superfluos check now
completely.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 08/30/18, 13:40

  2. TYPO3com voted on patch set 1 V -1 08/30/18, 13:45 Completed build in 05m 10s on Thu, 30 Aug, 03:45 PM Test Summary: 1 of 406 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27312

  3. TYPO3com voted on patch set 1 V +1 08/30/18, 13:57 Completed build in 22m 40s on Thu, 30 Aug, 03:57 PM Test Summary: 35334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27312

  4. Oliver Hader voted on patch set 1 CR +1 08/30/18, 14:05

  5. Oliver Hader voted on patch set 1 V +1 08/30/18, 14:05

  6. Oliver Hader commented on patch set 1 08/30/18, 14:06

    Find, the additional schema comparison was superfluous before, since it checked for forceAbsoluteUrl back then as well (which was always true in that if-branch)
  7. Oliver Hader commented on patch set 1 V +2 CR +2 08/30/18, 14:09

    No-brainer by comparing with patch-set that introduced this regression
  8. Oliver Hader merged patch set 2 08/30/18, 14:09