Review main Merged

58090[BUGFIX] Ensure new @import syntax is loaded properly

Benni Mack CR +2 V +2 Easy +30 −2 updated 08/30/18, 17:03

Commit message

The new @import TypoScript syntax only works
if there is an empty line before, so this should
be added - to be exactly in line with the <INCLUDE_TYPOSCRIPT>
syntax.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Susi Moog +1
  • Verified V +2
    • Wouter Wolters +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 69

  1. Benni Mack uploaded patch set 1 08/30/18, 13:53

  2. TYPO3com voted on patch set 1 V -1 08/30/18, 14:02 Completed build in 08m 30s on Thu, 30 Aug, 04:02 PM Test Summary: 21 of 35568 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27314

  3. Benni Mack uploaded patch set 2 08/30/18, 15:04

  4. Benni Mack uploaded patch set 3 08/30/18, 15:04

  5. TYPO3com voted on patch set 2 V +1 08/30/18, 15:15 Completed build in 10m 45s on Thu, 30 Aug, 05:15 PM Test Summary: 35388 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27319

  6. TYPO3com voted on patch set 3 V +1 08/30/18, 15:16 Completed build in 11m 09s on Thu, 30 Aug, 05:16 PM Test Summary: 35391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27320

  7. Susi Moog voted on patch set 3 V +1 CR +1 08/30/18, 16:36

  8. Wouter Wolters voted on patch set 3 V +2 CR +2 08/30/18, 17:03

  9. Wouter Wolters merged patch set 4 08/30/18, 17:03