Review main Merged

58093[TASK] Inject PSR-7 data in TSFE methods

Benni Mack CR +2 V +2 Normal +131 −31 updated 08/31/18, 07:34

Commit message

The following public methods within TSFE now get a PSR-7 request object
handed in to fetch the GET / POST variables.

- $TSFE->preparePageContentGeneration(ServerRequestInterface $request)
- $TSFE->calculateLinkVars(array $queryParams)
- $TSFE->makeCacheHash()

Note: If a hook modified _GET and preparePageContentGeneration
is called from Core, the state of _GET and $request->getQueryParams()
will differ. This COULD be overcome by using GeneralUtility::_GETset()
which TYPO3 Core and extensions like realurl already use.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Frans Saris +1
  • Verified V +2
    • Georg Ringer +2
    • Frans Saris +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1014

  1. Benni Mack uploaded patch set 1 08/30/18, 20:48

  2. TYPO3com voted on patch set 1 V -1 08/30/18, 20:48 Completed build in 22s on Thu, 30 Aug, 10:48 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27359

  3. Benni Mack uploaded patch set 2 08/30/18, 20:48

  4. TYPO3com voted on patch set 2 V -1 08/30/18, 21:00 Completed build in 11m 20s on Thu, 30 Aug, 11:00 PM Test Summary: 69 of 35610 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27360

  5. Benni Mack uploaded patch set 3 08/30/18, 21:11

  6. TYPO3com voted on patch set 3 V -1 08/30/18, 21:22 Completed build in 10m 41s on Thu, 30 Aug, 11:22 PM Test Summary: 15 of 35610 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27364

  7. Benni Mack uploaded patch set 4 08/30/18, 21:29

  8. TYPO3com voted on patch set 4 V +1 08/30/18, 21:39 Completed build in 09m 59s on Thu, 30 Aug, 11:39 PM Test Summary: 35376 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27368

  9. Frans Saris voted on patch set 4 CR +1 08/31/18, 07:09

  10. Frans Saris voted on patch set 4 V +1 08/31/18, 07:16

  11. Wouter Wolters voted on patch set 4 CR +1 08/31/18, 07:27

  12. Georg Ringer voted on patch set 4 V +1 CR +1 08/31/18, 07:33

  13. Georg Ringer voted on patch set 4 V +2 CR +2 08/31/18, 07:34

  14. Georg Ringer merged patch set 5 08/31/18, 07:34