Review main Merged

58095[TASK] Cleanup unused PageUriBuilder options

Benni Mack CR +2 V +2 Normal +30 −36 updated 09/02/18, 11:47

Commit message

Due to the refactoring of the typolink method, the PageUriBuilder
is now only used for links to pages with a site configuration, so it
can be cleaned up.

This a first step in getting the PageUriBuilder API in shape.

As this class is new, and the options and the class is not public
API yet, this removal does not need any docs.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Wouter Wolters +1
    • Frans Saris +1
  • Verified V +2
    • Jigal van Hemert +2
    • Frans Saris +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1012

  1. Benni Mack uploaded patch set 1 08/31/18, 07:29

  2. TYPO3com voted on patch set 1 V +1 08/31/18, 07:38 Completed build in 08m 52s on Fri, 31 Aug, 09:38 AM Test Summary: 35364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27379

  3. Frans Saris voted on patch set 1 CR +1 08/31/18, 09:18

  4. Frans Saris commented on patch set 1 V -1 CR 0 08/31/18, 09:24

    url generated in the backend (preview links) are after appliyng the patch not "translated" anymore to the speaking urls
  5. Benni Mack uploaded patch set 2 08/31/18, 09:38

  6. TYPO3com voted on patch set 2 V +1 08/31/18, 09:46 Completed build in 08m 07s on Fri, 31 Aug, 11:46 AM Test Summary: 35290 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27399

  7. Frans Saris voted on patch set 2 V +1 CR +1 08/31/18, 13:58

  8. Daniel Goerz commented on patch set 2 08/31/18, 14:47

    PageUriBuilder.php:90

    Isn't this line potentially harmful because $siteLanguage is used and checked for a few lines below?
  9. Benni Mack commented on patch set 2 08/31/18, 15:36

    PageUriBuilder.php:90 Reply

    where exactly?
  10. Wouter Wolters voted on patch set 2 CR +1 09/01/18, 09:36

  11. Jigal van Hemert voted on patch set 2 V +2 CR +2 09/02/18, 11:47

  12. Jigal van Hemert merged patch set 3 09/02/18, 11:47