58095[TASK] Cleanup unused PageUriBuilder options
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Wouter Wolters +1
- Frans Saris +1
-
Verified V +2
- Jigal van Hemert +2
- Frans Saris +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1012
-
Benni Mack uploaded patch set 1 08/31/18, 07:29
-
TYPO3com voted on patch set 1 V +1 08/31/18, 07:38 Completed build in 08m 52s on Fri, 31 Aug, 09:38 AM Test Summary: 35364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27379
-
Frans Saris voted on patch set 1 CR +1 08/31/18, 09:18
-
Frans Saris commented on patch set 1 V -1 CR 0 08/31/18, 09:24
url generated in the backend (preview links) are after appliyng the patch not "translated" anymore to the speaking urls -
Benni Mack uploaded patch set 2 08/31/18, 09:38
-
TYPO3com voted on patch set 2 V +1 08/31/18, 09:46 Completed build in 08m 07s on Fri, 31 Aug, 11:46 AM Test Summary: 35290 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27399
-
Frans Saris voted on patch set 2 V +1 CR +1 08/31/18, 13:58
-
Daniel Goerz commented on patch set 2 08/31/18, 14:47
PageUriBuilder.php:90Isn't this line potentially harmful because $siteLanguage is used and checked for a few lines below? -
Benni Mack commented on patch set 2 08/31/18, 15:36
PageUriBuilder.php:90Replywhere exactly? -
Wouter Wolters voted on patch set 2 CR +1 09/01/18, 09:36
-
Jigal van Hemert voted on patch set 2 V +2 CR +2 09/02/18, 11:47
-
Jigal van Hemert merged patch set 3 09/02/18, 11:47