Review main Merged

58096[BUGFIX] Pass record info when determining defaultUploadFolder in FileBrowser

Frans Saris CR +2 V +2 Normal +73 −4 updated 10/29/18, 18:41

Commit message

The fileBrowser now passes the related pid, table and field to
getDefaultUploadFolder().

Review

  • Code review CR +2
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1519

  1. Frans Saris uploaded patch set 1 08/31/18, 08:21

  2. TYPO3com voted on patch set 1 V +1 08/31/18, 08:31 Completed build in 09m 12s on Fri, 31 Aug, 10:31 AM Test Summary: 35364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27389

  3. Wouter Wolters updated the commit message in patch set 2 08/31/18, 08:49

  4. TYPO3com voted on patch set 2 V +1 08/31/18, 08:59 Completed build in 09m 32s on Fri, 31 Aug, 10:59 AM Test Summary: 35364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27393

  5. Markus Klein voted on patch set 2 CR +1 08/31/18, 10:12

  6. Wouter Wolters voted on patch set 2 CR +1 09/01/18, 09:39

  7. Markus Klein commented on patch set 2 CR 0 09/01/18, 10:17

    FileBrowser.php:166

    is this really always set? 4 is documented as: IRRE uniqueness: target level object-id to perform actions/checks on e.g. data[79][tt_address][1][<field>][<foreign_table>] I see no dashes in the example here. So either the documentation of bparams is wrong, or this code does not match
  8. Benni Mack updated the commit message in patch set 3 10/28/18, 12:19

  9. TYPO3com voted on patch set 3 V +1 10/28/18, 12:33 Completed build in 13m 08s on Sun, 28 Oct, 01:33 PM Test Summary: 37843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29744

  10. Susi Moog commented on patch set 3 CR -1 10/28/18, 13:07

    on it
  11. Susi Moog uploaded patch set 4 10/28/18, 13:12

  12. Susi Moog commented on patch set 4 10/28/18, 13:14

    FileBrowser.php:191

    makes testing easier, that's why I included this change (prevents notice in test)
  13. Susi Moog commented on patch set 2 10/28/18, 13:15

    FileBrowser.php:166 Reply

    the example is wrong, I checked the bparams generated (and wrote a test with the live data and adjusted the example). as for is it always set: if bparams is set at all, then yes it seems, if it's not set, it fails much earlier already as all explodes here don't include checks.
  14. TYPO3com voted on patch set 4 V +1 10/28/18, 13:55 Completed build in 21m 19s on Sun, 28 Oct, 02:55 PM Test Summary: 37867 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29763

  15. Susi Moog voted on patch set 4 V +1 CR +1 10/29/18, 10:00

  16. Benni Mack voted on patch set 4 V +2 CR +2 10/29/18, 10:01

  17. Benni Mack merged patch set 5 10/29/18, 10:01

  18. Benni Mack commented on patch set 5 10/29/18, 10:01

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 46967b035be16d416c84047028594ce0dc4da85e
  19. Frans Saris commented on patch set 5 10/29/18, 18:41

    Tnx for taking care