58096[BUGFIX] Pass record info when determining defaultUploadFolder in FileBrowser
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Susi Moog +1
-
Verified V +2
- Benni Mack +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1519
-
Frans Saris uploaded patch set 1 08/31/18, 08:21
-
TYPO3com voted on patch set 1 V +1 08/31/18, 08:31 Completed build in 09m 12s on Fri, 31 Aug, 10:31 AM Test Summary: 35364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27389
-
Wouter Wolters updated the commit message in patch set 2 08/31/18, 08:49
-
TYPO3com voted on patch set 2 V +1 08/31/18, 08:59 Completed build in 09m 32s on Fri, 31 Aug, 10:59 AM Test Summary: 35364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27393
-
Markus Klein voted on patch set 2 CR +1 08/31/18, 10:12
-
Wouter Wolters voted on patch set 2 CR +1 09/01/18, 09:39
-
Markus Klein commented on patch set 2 CR 0 09/01/18, 10:17
-
Benni Mack updated the commit message in patch set 3 10/28/18, 12:19
-
TYPO3com voted on patch set 3 V +1 10/28/18, 12:33 Completed build in 13m 08s on Sun, 28 Oct, 01:33 PM Test Summary: 37843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29744
-
Susi Moog commented on patch set 3 CR -1 10/28/18, 13:07
on it -
Susi Moog uploaded patch set 4 10/28/18, 13:12
-
Susi Moog commented on patch set 4 10/28/18, 13:14
FileBrowser.php:191makes testing easier, that's why I included this change (prevents notice in test) -
Susi Moog commented on patch set 2 10/28/18, 13:15
FileBrowser.php:166Replythe example is wrong, I checked the bparams generated (and wrote a test with the live data and adjusted the example). as for is it always set: if bparams is set at all, then yes it seems, if it's not set, it fails much earlier already as all explodes here don't include checks. -
TYPO3com voted on patch set 4 V +1 10/28/18, 13:55 Completed build in 21m 19s on Sun, 28 Oct, 02:55 PM Test Summary: 37867 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29763
-
Susi Moog voted on patch set 4 V +1 CR +1 10/29/18, 10:00
-
Benni Mack voted on patch set 4 V +2 CR +2 10/29/18, 10:01
-
Benni Mack merged patch set 5 10/29/18, 10:01
-
Benni Mack commented on patch set 5 10/29/18, 10:01
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 46967b035be16d416c84047028594ce0dc4da85e -
Frans Saris commented on patch set 5 10/29/18, 18:41
Tnx for taking care
FileBrowser.php:166