58100[BUGFIX] Ensure to use parent's page slug for generating a new pages' slug
Commit message
Review
-
Code review CR +2
- Frans Saris +2
- Wouter Wolters +1
- Francois Suter +1
-
Verified V +2
- Frans Saris +2
- Francois Suter +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 911
-
Benni Mack uploaded patch set 1 08/31/18, 09:43
-
Francois Suter commented on patch set 1 V +1 CR +1 08/31/18, 09:49
Perfect, thanks! -
TYPO3com voted on patch set 1 V +1 08/31/18, 09:53 Completed build in 09m 50s on Fri, 31 Aug, 11:53 AM Test Summary: 35290 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27400
-
Frans Saris commented on patch set 1 08/31/18, 10:03
SlugHelper.php:154why ` ?? ''` Shouldn't be needed as the `empty()` already catches the `undefined index` error, doesn't? so `if ($parentPageRecord['slug'] ?? '' !== '') {` or `if (!empty($parentPageRecord['slug'])) {` -
Frans Saris voted on patch set 1 V +1 CR -1 08/31/18, 10:06
-
Benni Mack commented on patch set 2 08/31/18, 10:08
Published edit on patch set 1. -
Francois Suter commented on patch set 2 V +1 CR +1 08/31/18, 10:12
Sorry for reviewing the code a bit too fast the first time. -
TYPO3com voted on patch set 2 V +1 08/31/18, 10:17 Completed build in 09m 19s on Fri, 31 Aug, 12:17 PM Test Summary: 35290 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27407
-
Wouter Wolters voted on patch set 2 CR +1 08/31/18, 11:36
-
Frans Saris voted on patch set 2 V +2 CR +2 08/31/18, 12:10
-
Frans Saris merged patch set 3 08/31/18, 12:10