Review main Merged

58102[BUGFIX] Expression Language should not crash Backend Modules

Benni Mack CR +2 V +2 Easy +4 −2 updated 08/31/18, 14:00

Commit message

When doing "[page["uid"] >= 284]" in a TypoScript condition, everything works
as expected in Frontend, but in BE it gets messy, as "page" HAS to be an array
to allow to validate this, but page does not always exist.

This comes from a wrong spec, claiming that conditionMatcher->getPage() always
returns an array, which is wrong. So let's make the code return an array all the time.

Review

  • Code review CR +2
    • Frans Saris +2
    • Frank Nägler +1
    • Andreas Kienast +1
  • Verified V +2
    • Frans Saris +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Benni Mack uploaded patch set 1 08/31/18, 12:18

  2. Andreas Kienast voted on patch set 1 CR +1 08/31/18, 12:20

  3. TYPO3com voted on patch set 1 V +1 08/31/18, 12:27 Completed build in 08m 57s on Fri, 31 Aug, 02:27 PM Test Summary: 35290 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27420

  4. Frank Nägler voted on patch set 1 CR +1 08/31/18, 12:34

  5. Frank Nägler voted on patch set 1 V +1 08/31/18, 12:52

  6. Frans Saris voted on patch set 1 V +2 CR +2 08/31/18, 14:00

  7. Frans Saris merged patch set 2 08/31/18, 14:00