Review main Merged

58106[BUGFIX] Registration of multiple additional view models

Ralf Zimmermann CR +2 V +2 Easy +17 −8 updated 10/28/18, 14:41

Commit message

The form setup properties within "additionalViewModelModules" must be
written as numerical associative arrays to make it possible that
multiple extensions can extend the form editor with javascript modules.

Review

  • Code review CR +2
    • Benni Mack +2
    • Daniel Goerz +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1214

  1. Ralf Zimmermann uploaded patch set 1 08/31/18, 17:18

  2. TYPO3com voted on patch set 1 V +1 08/31/18, 17:28 Completed build in 10m 41s on Fri, 31 Aug, 07:28 PM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27443

  3. Jörg Bösche voted on patch set 1 CR +1 09/02/18, 12:13

  4. Andreas Wolf voted on patch set 1 CR +2 09/02/18, 14:44

  5. Julian Wundrak voted on patch set 1 CR +1 09/03/18, 07:02

  6. Tobi Kretschmann voted on patch set 1 CR +1 09/19/18, 13:06

  7. Jan Stockfisch commented on patch set 1 CR -1 10/01/18, 09:05

    FormEditor.js:979

    Should also be removed
  8. Jan Stockfisch commented on patch set 2 10/01/18, 09:07

    Published edit on patch set 1.
  9. TYPO3com voted on patch set 2 V +1 10/01/18, 09:17 Completed build in 09m 44s on Mon, 1 Oct, 11:17 AM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29119

  10. Daniel Goerz voted on patch set 2 CR +1 10/27/18, 15:19

  11. Susi Moog voted on patch set 2 V +1 CR +1 10/28/18, 14:37

  12. Benni Mack voted on patch set 2 V +2 CR +2 10/28/18, 14:41

  13. Benni Mack merged patch set 3 10/28/18, 14:41

  14. Benni Mack commented on patch set 3 10/28/18, 14:41

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 7088f0c4c389f446715ddb4fe80163b0736d6e16