58108[BUGFIX] Allow page links to different languages within a site
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Christian Kuhn +1
- Susi Moog +1
-
Verified V +2
- Oliver Hader +2
- Christian Kuhn +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php2+44 −4
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+10 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php+99 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LinkGeneratorTest.php+57 −77
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+99 −75
Review log 3042
Show 1117 earlier messages
-
Benni Mack uploaded patch set 1 08/31/18, 20:58
-
TYPO3com voted on patch set 1 V -1 08/31/18, 21:10 Completed build in 11m 55s on Fri, 31 Aug, 11:10 PM Test Summary: 36 of 36178 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27448
-
Frans Saris commented on patch set 1 08/31/18, 21:36
-
Richard Haeser uploaded patch set 2 09/01/18, 15:48
-
TYPO3com voted on patch set 2 V -1 09/01/18, 15:49 Completed build in 09s on Sat, 1 Sep, 05:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27489
-
Richard Haeser uploaded patch set 3 09/01/18, 15:52
-
TYPO3com voted on patch set 3 V -1 09/01/18, 16:01 Completed build in 09m 19s on Sat, 1 Sep, 06:02 PM Test Summary: 24 of 36175 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27490
-
Kevin Appelt voted on patch set 3 V +1 09/01/18, 16:54
-
Kevin Appelt voted on patch set 3 CR +1 09/01/18, 18:58
-
Oliver Hader commented on patch set 3 09/01/18, 19:32
I'm adding some tests soon and will check the failing tests -
Oliver Hader uploaded patch set 4 09/01/18, 19:39
-
TYPO3com voted on patch set 4 V -1 09/01/18, 19:50 Completed build in 10m 45s on Sat, 1 Sep, 09:50 PM Test Summary: 54 of 36280 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27503
-
Oliver Hader uploaded patch set 5 09/02/18, 07:45
-
Oliver Hader uploaded patch set 6 09/02/18, 07:46
-
TYPO3com voted on patch set 5 V -1 09/02/18, 07:53 Completed build in 07m 42s on Sun, 2 Sep, 09:53 AM Test Summary: 29485 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27531
-
TYPO3com voted on patch set 6 V +1 09/02/18, 07:57 Completed build in 11m 12s on Sun, 2 Sep, 09:57 AM Test Summary: 36025 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27532
-
Oliver Hader commented on patch set 6 09/02/18, 18:03
PageLinkBuilder.php:189array_replace_recursive
-
Oliver Hader uploaded patch set 7 09/02/18, 19:22
-
TYPO3com voted on patch set 7 V -1 09/02/18, 19:23 Completed build in 13s on Sun, 2 Sep, 09:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27590
-
Frans Saris voted on patch set 7 V +1 CR +1 09/03/18, 06:28
-
Oliver Hader uploaded patch set 8 09/03/18, 07:10
-
TYPO3com voted on patch set 8 V +1 09/03/18, 07:19 Completed build in 08m 10s on Mon, 3 Sep, 09:19 AM Test Summary: 36025 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27608
-
Frans Saris voted on patch set 8 V +1 CR +1 09/03/18, 10:52
-
Christian Kuhn voted on patch set 8 V -1 09/03/18, 10:55
-
Oliver Hader uploaded patch set 9 09/03/18, 11:16
-
TYPO3com voted on patch set 9 V +1 09/03/18, 11:29 Completed build in 12m 53s on Mon, 3 Sep, 01:29 PM Test Summary: 36031 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27624
-
Benni Mack commented on patch set 9 CR -1 09/03/18, 11:29
won't work, as PageRepository will do wrong caching here. sry. -
Benni Mack uploaded patch set 10 09/03/18, 11:31
-
Christian Kuhn commented on patch set 10 V -1 09/03/18, 11:35
i'm now receiving 'PageNotFoundException' for basically all FE urls -
Oliver Hader uploaded patch set 11 09/03/18, 11:41
-
Oliver Hader commented on patch set 10 09/03/18, 11:42
PageRepository.php:313I've overridden this change since it also won't inform existing hooks without being breaking... -
Christian Kuhn voted on patch set 11 V +1 09/03/18, 11:47
-
Christian Kuhn voted on patch set 11 CR +1 09/03/18, 11:51
-
Susi Moog commented on patch set 11 V +1 09/03/18, 11:59
tested with multilang site, menuprocessor and href lang generator -
TYPO3com voted on patch set 10 V -1 09/03/18, 12:04 Completed build in 23m 33s on Mon, 3 Sep, 02:04 PM Test Summary: 4316 of 36304 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27631
-
TYPO3com voted on patch set 11 V -1 09/03/18, 12:14 Completed build in 13m 22s on Mon, 3 Sep, 02:14 PM Test Summary: 21 of 36304 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27635
-
Oliver Hader uploaded patch set 12 09/03/18, 12:20
-
Christian Kuhn voted on patch set 12 V +1 CR +1 09/03/18, 12:24
-
Susi Moog voted on patch set 12 V +1 CR +1 09/03/18, 12:25
-
TYPO3com voted on patch set 12 V +1 09/03/18, 12:29 Completed build in 08m 57s on Mon, 3 Sep, 02:29 PM Test Summary: 36010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27639
-
Oliver Hader voted on patch set 12 V +2 CR +2 09/03/18, 12:30
-
Oliver Hader merged patch set 13 09/03/18, 12:30
PageLinkBuilder.php:184