Review main Merged

58108[BUGFIX] Allow page links to different languages within a site

Benni Mack CR +2 V +2 Hard +309 −156 updated 09/03/18, 12:30

Commit message

Due to the refactoring process within links to a site, it is still
necessary to link to a translated page with a given "&L=" parameter.
This parameter is resolved, and a link to a page translation
is generated.

Fixes menu generation and typolink with the generated page title.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Christian Kuhn +1
    • Susi Moog +1
  • Verified V +2
    • Oliver Hader +2
    • Christian Kuhn +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 3042

Show 1117 earlier messages
  1. Benni Mack uploaded patch set 1 08/31/18, 20:58

  2. TYPO3com voted on patch set 1 V -1 08/31/18, 21:10 Completed build in 11m 55s on Fri, 31 Aug, 11:10 PM Test Summary: 36 of 36178 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27448

  3. Frans Saris commented on patch set 1 08/31/18, 21:36

    PageLinkBuilder.php:184

    What if $conf[language] already is present?
  4. Richard Haeser uploaded patch set 2 09/01/18, 15:48

  5. TYPO3com voted on patch set 2 V -1 09/01/18, 15:49 Completed build in 09s on Sat, 1 Sep, 05:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27489

  6. Richard Haeser uploaded patch set 3 09/01/18, 15:52

  7. TYPO3com voted on patch set 3 V -1 09/01/18, 16:01 Completed build in 09m 19s on Sat, 1 Sep, 06:02 PM Test Summary: 24 of 36175 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27490

  8. Kevin Appelt voted on patch set 3 V +1 09/01/18, 16:54

  9. Kevin Appelt voted on patch set 3 CR +1 09/01/18, 18:58

  10. Oliver Hader commented on patch set 3 09/01/18, 19:32

    I'm adding some tests soon and will check the failing tests
  11. Oliver Hader uploaded patch set 4 09/01/18, 19:39

  12. TYPO3com voted on patch set 4 V -1 09/01/18, 19:50 Completed build in 10m 45s on Sat, 1 Sep, 09:50 PM Test Summary: 54 of 36280 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27503

  13. Oliver Hader uploaded patch set 5 09/02/18, 07:45

  14. Oliver Hader uploaded patch set 6 09/02/18, 07:46

  15. TYPO3com voted on patch set 5 V -1 09/02/18, 07:53 Completed build in 07m 42s on Sun, 2 Sep, 09:53 AM Test Summary: 29485 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27531

  16. TYPO3com voted on patch set 6 V +1 09/02/18, 07:57 Completed build in 11m 12s on Sun, 2 Sep, 09:57 AM Test Summary: 36025 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27532

  17. Oliver Hader commented on patch set 6 09/02/18, 18:03

    PageLinkBuilder.php:189

    array_replace_recursive
  1. Oliver Hader uploaded patch set 7 09/02/18, 19:22

  2. TYPO3com voted on patch set 7 V -1 09/02/18, 19:23 Completed build in 13s on Sun, 2 Sep, 09:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27590

  3. Frans Saris voted on patch set 7 V +1 CR +1 09/03/18, 06:28

  4. Oliver Hader uploaded patch set 8 09/03/18, 07:10

  5. TYPO3com voted on patch set 8 V +1 09/03/18, 07:19 Completed build in 08m 10s on Mon, 3 Sep, 09:19 AM Test Summary: 36025 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27608

  6. Frans Saris voted on patch set 8 V +1 CR +1 09/03/18, 10:52

  7. Christian Kuhn voted on patch set 8 V -1 09/03/18, 10:55

  8. Oliver Hader uploaded patch set 9 09/03/18, 11:16

  9. TYPO3com voted on patch set 9 V +1 09/03/18, 11:29 Completed build in 12m 53s on Mon, 3 Sep, 01:29 PM Test Summary: 36031 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27624

  10. Benni Mack commented on patch set 9 CR -1 09/03/18, 11:29

    won't work, as PageRepository will do wrong caching here. sry.
  11. Benni Mack uploaded patch set 10 09/03/18, 11:31

  12. Christian Kuhn commented on patch set 10 V -1 09/03/18, 11:35

    i'm now receiving 'PageNotFoundException' for basically all FE urls
  13. Oliver Hader uploaded patch set 11 09/03/18, 11:41

  14. Oliver Hader commented on patch set 10 09/03/18, 11:42

    PageRepository.php:313

    I've overridden this change since it also won't inform existing hooks without being breaking...
  15. Christian Kuhn voted on patch set 11 V +1 09/03/18, 11:47

  16. Christian Kuhn voted on patch set 11 CR +1 09/03/18, 11:51

  17. Susi Moog commented on patch set 11 V +1 09/03/18, 11:59

    tested with multilang site, menuprocessor and href lang generator
  18. TYPO3com voted on patch set 10 V -1 09/03/18, 12:04 Completed build in 23m 33s on Mon, 3 Sep, 02:04 PM Test Summary: 4316 of 36304 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27631

  19. TYPO3com voted on patch set 11 V -1 09/03/18, 12:14 Completed build in 13m 22s on Mon, 3 Sep, 02:14 PM Test Summary: 21 of 36304 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27635

  20. Oliver Hader uploaded patch set 12 09/03/18, 12:20

  21. Christian Kuhn voted on patch set 12 V +1 CR +1 09/03/18, 12:24

  22. Susi Moog voted on patch set 12 V +1 CR +1 09/03/18, 12:25

  23. TYPO3com voted on patch set 12 V +1 09/03/18, 12:29 Completed build in 08m 57s on Mon, 3 Sep, 02:29 PM Test Summary: 36010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27639

  24. Oliver Hader voted on patch set 12 V +2 CR +2 09/03/18, 12:30

  25. Oliver Hader merged patch set 13 09/03/18, 12:30