58110[TASK] Refine DebugExceptionHandler
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Wouter Wolters +1
- Susi Moog +1
-
Verified V +2
- Andreas Kienast +2
- Kevin Appelt +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2229
Show 24 earlier messages
-
Markus Poerschke uploaded patch set 1 09/01/18, 01:50
-
TYPO3com voted on patch set 1 V -1 09/01/18, 02:02 Completed build in 12m 25s on Sat, 1 Sep, 04:02 AM Test Summary: 3 of 36178 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27452
-
Markus Poerschke uploaded patch set 2 09/01/18, 02:11
-
TYPO3com voted on patch set 2 V -1 09/01/18, 02:20 Completed build in 09m 25s on Sat, 1 Sep, 04:20 AM Test Summary: 3 of 36178 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27453
-
Markus Poerschke uploaded patch set 3 09/01/18, 09:02
-
Markus Klein commented on patch set 3 09/01/18, 09:04
Hi! Thanks for you patch. Bamboo votes -1 also because you need to provide a .rst documentation file for new features. Since this is not a new feature in the technical sense (more in the marketing sense), I would suggest to change it from [FEATURE] to [TASK]. Benefits: no .rst file needed, and not bound to feature freeze, so can be reviewed and merged after Monday as well. -
Markus Poerschke updated the commit message in patch set 4 09/01/18, 09:06
-
TYPO3com voted on patch set 3 V +1 09/01/18, 09:13 Completed build in 10m 25s on Sat, 1 Sep, 11:13 AM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27455
-
TYPO3com voted on patch set 4 V +1 09/01/18, 09:18 Completed build in 11m 45s on Sat, 1 Sep, 11:18 AM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27456
-
Markus Klein commented on patch set 4 09/01/18, 09:36
DebugExceptionHandler.php:34why do we need that? The core never uses this php setting, but uses what is configured in TypoScript, which might not be available of course when an exception occurs. I suggest to always go with utf8 in case of an exception.DebugExceptionHandler.php:132please remove trailing whitespace. IDEs should do so automaticially, but I'm not sure if this is the case within heredocs too.DebugExceptionHandler.php:466please use without backslashDebugExceptionHandler.php:477same hereDebugExceptionHandler.php:488no need for a phpdoc if it does not contain more information than the method signature already does.DebugExceptionHandler.php:499and all places here as wellDebugExceptionHandler.php:525We usually declare most functions protected, to keep them mockable for unit tests -
Markus Poerschke uploaded patch set 5 09/01/18, 15:29
-
Markus Poerschke commented on patch set 5 09/01/18, 15:30
> Patch Set 4: > > (7 comments) Thanks for your feedback. I changed my patch.DebugExceptionHandler.php:34ReplyDoneDebugExceptionHandler.php:132ReplyDoneDebugExceptionHandler.php:466ReplyDoneDebugExceptionHandler.php:477ReplyDoneDebugExceptionHandler.php:488ReplyDoneDebugExceptionHandler.php:499ReplyDoneDebugExceptionHandler.php:525ReplyDone -
TYPO3com voted on patch set 5 V +1 09/01/18, 15:39 Completed build in 10m 44s on Sat, 1 Sep, 05:39 PM Test Summary: 35902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27485
-
Markus Klein uploaded patch set 6 09/01/18, 19:01
-
TYPO3com voted on patch set 6 V +1 09/01/18, 19:11 Completed build in 10m 23s on Sat, 1 Sep, 09:11 PM Test Summary: 35929 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27498
-
Markus Klein voted on patch set 6 CR +1 09/01/18, 19:17
-
Susi Moog commented on patch set 6 V +1 CR +1 09/01/18, 19:26
whoa, pretty cool. thanks for this one! -
Wouter Wolters commented on patch set 6 09/01/18, 19:33
DebugExceptionHandler.php:354$trace missing -
Kevin Appelt voted on patch set 6 V +1 09/01/18, 19:33
-
Susi Moog commented on patch set 7 09/01/18, 19:37
Published edit on patch set 6. -
Wouter Wolters voted on patch set 7 CR +1 09/01/18, 19:37
-
Kevin Appelt voted on patch set 7 V +1 09/01/18, 19:38
-
TYPO3com voted on patch set 7 V +1 09/01/18, 19:46 Completed build in 09m 44s on Sat, 1 Sep, 09:46 PM Test Summary: 35929 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27502
-
Andreas Kienast voted on patch set 7 V +1 CR +1 09/01/18, 19:50
-
Susi Moog voted on patch set 7 V +1 CR +1 09/01/18, 19:51
-
Andreas Kienast voted on patch set 7 V +2 CR +2 09/01/18, 19:52
-
Andreas Kienast merged patch set 8 09/01/18, 19:52
-
Markus Klein commented on patch set 6 V +1 09/01/18, 20:14
cool. I like it. -
Christian Kuhn commented on patch set 8 09/03/18, 02:26
this does not work very well in some cases: if an exception is thrown in the content frame, there is no scroll bar and you can not see the full backtrace. Additionally, if "lots of" data is given as method arguments, the argument backtrace can become extremely long.