Review main Merged

58110[TASK] Refine DebugExceptionHandler

Markus Poerschke CR +2 V +2 Hard +469 −114 updated 09/03/18, 02:26

Commit message

* Complete new design for the uncaught exception error page
* Show all exceptions by calling all ->getPreviousException
* Show function / method arguments with more detail
* Show code where exception was thrown

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Susi Moog +1
  • Verified V +2
    • Andreas Kienast +2
    • Kevin Appelt +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2229

Show 24 earlier messages
  1. Markus Poerschke uploaded patch set 1 09/01/18, 01:50

  2. TYPO3com voted on patch set 1 V -1 09/01/18, 02:02 Completed build in 12m 25s on Sat, 1 Sep, 04:02 AM Test Summary: 3 of 36178 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27452

  3. Markus Poerschke uploaded patch set 2 09/01/18, 02:11

  4. TYPO3com voted on patch set 2 V -1 09/01/18, 02:20 Completed build in 09m 25s on Sat, 1 Sep, 04:20 AM Test Summary: 3 of 36178 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27453

  1. Markus Poerschke uploaded patch set 3 09/01/18, 09:02

  2. Markus Klein commented on patch set 3 09/01/18, 09:04

    Hi! Thanks for you patch. Bamboo votes -1 also because you need to provide a .rst documentation file for new features. Since this is not a new feature in the technical sense (more in the marketing sense), I would suggest to change it from [FEATURE] to [TASK]. Benefits: no .rst file needed, and not bound to feature freeze, so can be reviewed and merged after Monday as well.
  3. Markus Poerschke updated the commit message in patch set 4 09/01/18, 09:06

  4. TYPO3com voted on patch set 3 V +1 09/01/18, 09:13 Completed build in 10m 25s on Sat, 1 Sep, 11:13 AM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27455

  5. TYPO3com voted on patch set 4 V +1 09/01/18, 09:18 Completed build in 11m 45s on Sat, 1 Sep, 11:18 AM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27456

  6. Markus Klein commented on patch set 4 09/01/18, 09:36

    DebugExceptionHandler.php:34

    why do we need that? The core never uses this php setting, but uses what is configured in TypoScript, which might not be available of course when an exception occurs. I suggest to always go with utf8 in case of an exception.

    DebugExceptionHandler.php:132

    please remove trailing whitespace. IDEs should do so automaticially, but I'm not sure if this is the case within heredocs too.

    DebugExceptionHandler.php:466

    please use without backslash

    DebugExceptionHandler.php:477

    same here

    DebugExceptionHandler.php:488

    no need for a phpdoc if it does not contain more information than the method signature already does.

    DebugExceptionHandler.php:499

    and all places here as well

    DebugExceptionHandler.php:525

    We usually declare most functions protected, to keep them mockable for unit tests
  7. Markus Poerschke uploaded patch set 5 09/01/18, 15:29

  8. Markus Poerschke commented on patch set 5 09/01/18, 15:30

    > Patch Set 4: > > (7 comments) Thanks for your feedback. I changed my patch.

    DebugExceptionHandler.php:34 Reply

    Done

    DebugExceptionHandler.php:132 Reply

    Done

    DebugExceptionHandler.php:466 Reply

    Done

    DebugExceptionHandler.php:477 Reply

    Done

    DebugExceptionHandler.php:488 Reply

    Done

    DebugExceptionHandler.php:499 Reply

    Done

    DebugExceptionHandler.php:525 Reply

    Done
  9. TYPO3com voted on patch set 5 V +1 09/01/18, 15:39 Completed build in 10m 44s on Sat, 1 Sep, 05:39 PM Test Summary: 35902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27485

  10. Markus Klein uploaded patch set 6 09/01/18, 19:01

  11. TYPO3com voted on patch set 6 V +1 09/01/18, 19:11 Completed build in 10m 23s on Sat, 1 Sep, 09:11 PM Test Summary: 35929 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27498

  12. Markus Klein voted on patch set 6 CR +1 09/01/18, 19:17

  13. Susi Moog commented on patch set 6 V +1 CR +1 09/01/18, 19:26

    whoa, pretty cool. thanks for this one!
  14. Wouter Wolters commented on patch set 6 09/01/18, 19:33

    DebugExceptionHandler.php:354

    $trace missing
  15. Kevin Appelt voted on patch set 6 V +1 09/01/18, 19:33

  16. Susi Moog commented on patch set 7 09/01/18, 19:37

    Published edit on patch set 6.
  17. Wouter Wolters voted on patch set 7 CR +1 09/01/18, 19:37

  18. Kevin Appelt voted on patch set 7 V +1 09/01/18, 19:38

  19. TYPO3com voted on patch set 7 V +1 09/01/18, 19:46 Completed build in 09m 44s on Sat, 1 Sep, 09:46 PM Test Summary: 35929 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27502

  20. Andreas Kienast voted on patch set 7 V +1 CR +1 09/01/18, 19:50

  21. Susi Moog voted on patch set 7 V +1 CR +1 09/01/18, 19:51

  22. Andreas Kienast voted on patch set 7 V +2 CR +2 09/01/18, 19:52

  23. Andreas Kienast merged patch set 8 09/01/18, 19:52

  24. Markus Klein commented on patch set 6 V +1 09/01/18, 20:14

    cool. I like it.
  25. Christian Kuhn commented on patch set 8 09/03/18, 02:26

    this does not work very well in some cases: if an exception is thrown in the content frame, there is no scroll bar and you can not see the full backtrace. Additionally, if "lots of" data is given as method arguments, the argument backtrace can become extremely long.