Review main Merged

58125[TASK] Use PHP_OS constant instead off php_uname('s')

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 09/02/18, 20:58

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Wouter Wolters uploaded patch set 1 09/02/18, 11:11

  2. TYPO3com voted on patch set 1 V +1 09/02/18, 11:19 Completed build in 07m 39s on Sun, 2 Sep, 01:19 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27546

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 09/02/18, 11:39

  4. Anja Leichsenring merged patch set 2 09/02/18, 11:50

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 09/02/18, 11:50

  6. Markus Klein commented on patch set 2 09/02/18, 20:58

    a few words about the "why" in the ticket or the commit message would have been nice.
    of