Review main Abandoned

58126[WIP][TASK] Streamline shorthand methods for BE_USER,TSFE and LANG

Wouter Wolters CR 0 V 0 Expert +603 −559 updated 10/02/18, 06:00

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 205

Show 185 more files

Review log 1425

  1. Wouter Wolters uploaded patch set 1 09/02/18, 12:03

  2. TYPO3com voted on patch set 1 V -1 09/02/18, 12:13 Completed build in 09m 34s on Sun, 2 Sep, 02:13 PM Test Summary: 31 of 421 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27551

  3. Wouter Wolters uploaded patch set 2 09/02/18, 12:23

  4. TYPO3com voted on patch set 2 V -1 09/02/18, 12:31 Completed build in 07m 24s on Sun, 2 Sep, 02:31 PM Test Summary: 8832 of 36214 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27553

  5. Wouter Wolters uploaded patch set 3 09/02/18, 12:52

  6. TYPO3com voted on patch set 3 V -1 09/02/18, 13:02 Completed build in 10m 00s on Sun, 2 Sep, 03:02 PM Test Summary: 7233 of 36214 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27554

  7. Christian Kuhn uploaded patch set 4 09/02/18, 15:35

  8. TYPO3com voted on patch set 4 V -1 09/02/18, 15:45 Completed build in 10m 10s on Sun, 2 Sep, 05:45 PM Test Summary: 4550 of 36214 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27562

  9. Christian Kuhn uploaded patch set 5 09/02/18, 15:52

  10. Christian Kuhn uploaded patch set 6 09/02/18, 15:57

  11. TYPO3com voted on patch set 5 V -1 09/02/18, 16:00 Completed build in 08m 30s on Sun, 2 Sep, 06:00 PM Test Summary: 4325 of 36214 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27564

  12. Christian Kuhn uploaded patch set 7 09/02/18, 16:06

  13. TYPO3com voted on patch set 6 V -1 09/02/18, 16:07 Completed build in 09m 27s on Sun, 2 Sep, 06:07 PM Test Summary: 3766 of 36217 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27565

  14. Christian Kuhn uploaded patch set 8 09/02/18, 16:13

  15. Christian Kuhn uploaded patch set 9 09/02/18, 16:14

  16. TYPO3com voted on patch set 7 V -1 09/02/18, 16:19 Completed build in 12m 39s on Sun, 2 Sep, 06:19 PM Test Summary: 1049 of 36217 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27567

  17. Christian Kuhn uploaded patch set 10 09/02/18, 16:26

  18. TYPO3com voted on patch set 9 V -1 09/02/18, 16:27 Completed build in 12m 31s on Sun, 2 Sep, 06:27 PM Test Summary: 41 of 36217 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27570

  19. TYPO3com voted on patch set 8 V -1 09/02/18, 16:29 Completed build in 14m 37s on Sun, 2 Sep, 06:29 PM Test Summary: 281 of 36217 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27569

  20. TYPO3com voted on patch set 10 V -1 09/02/18, 16:35 Completed build in 08m 57s on Sun, 2 Sep, 06:35 PM Test Summary: 15 of 36217 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27571

  21. Christian Kuhn uploaded patch set 11 09/02/18, 16:38

  22. TYPO3com voted on patch set 11 V +1 09/02/18, 16:48 Completed build in 09m 58s on Sun, 2 Sep, 06:48 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27572

  23. Markus Klein commented on patch set 11 09/02/18, 20:55

    AbstractWizardController.php:64

    this is dangerous! specifically for TSFE. there might be cases where the return value is null.
  24. Christian Kuhn commented on patch set 11 09/03/18, 11:23

    yes. the entire patch is rather risky. and since it is so huge, the patch is also hard to review. maybe it would be better if we don't do this in v9 anymore.
  25. Benni Mack abandoned the change 10/02/18, 06:00

    I'll abandon this for now.