Review main Merged

58127[TASK] Add missing @return phpDoc tags

Wouter Wolters CR +2 V +2 Easy +5 −0 updated 09/02/18, 16:10

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 68

  1. Wouter Wolters uploaded patch set 1 09/02/18, 15:25

  2. TYPO3com voted on patch set 1 V -1 09/02/18, 15:25 Completed build in 12s on Sun, 2 Sep, 05:25 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27560

  3. Wouter Wolters uploaded patch set 2 09/02/18, 15:27

  4. TYPO3com voted on patch set 2 V +1 09/02/18, 15:36 Completed build in 09m 21s on Sun, 2 Sep, 05:36 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27561

  5. Susi Moog voted on patch set 2 V +1 CR +1 09/02/18, 15:43

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 09/02/18, 16:09

  7. Christian Kuhn merged patch set 3 09/02/18, 16:09

  8. Joerg Kummer commented on patch set 2 09/02/18, 16:10

    ElementHistoryController.php:205

    Could this also being boolean, if condition Line 217 does not match?