58129[TASK] Streamline PHPDoc comment matches function/method signature
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2
- Anja Leichsenring +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 59
- typo3/sysext/adminpanel/Classes/Middleware/AdminPanelDataPersister.php1+3 −0
- typo3/sysext/adminpanel/Classes/Middleware/AdminPanelRenderer.php+3 −0
- typo3/sysext/adminpanel/Classes/Middleware/SqlLogging.php+3 −0
- typo3/sysext/backend/Classes/Controller/File/RenameFileController.php+1 −0
- typo3/sysext/backend/Classes/Controller/Wizard/EditController.php+1 −1
- typo3/sysext/backend/Classes/Controller/OnlineMediaController.php+1 −0
- typo3/sysext/backend/Classes/Form/Container/AbstractContainer.php+1 −0
- typo3/sysext/backend/Classes/Provider/PageTsBackendLayoutDataProvider.php+2 −0
- typo3/sysext/backend/Classes/Toolbar/ClearCacheActionsHookInterface.php+0 −1
- typo3/sysext/backend/Classes/Tree/Renderer/UnorderedListTreeRenderer.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+1 −1
- typo3/sysext/backend/Classes/Tree/TreeNodeCollection.php+3 −0
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+1 −0
- typo3/sysext/core/Classes/Authentication/AuthenticationService.php+5 −9
- typo3/sysext/core/Classes/Database/Connection.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+2 −5
- typo3/sysext/core/Classes/Error/Http/StatusException.php+1 −1
- typo3/sysext/core/Classes/Imaging/ImageManipulation/CropVariantCollection.php2+1 −1
- typo3/sysext/core/Classes/Log/Processor/IntrospectionProcessor.php+2 −2
- typo3/sysext/core/Classes/Log/Writer/FileWriter.php+0 −1
Show 39 more files
- typo3/sysext/core/Classes/Page/PageRenderer.php+1 −1
- typo3/sysext/core/Classes/Resource/Processing/ImageCropScaleMaskTask.php+0 −1
- typo3/sysext/core/Classes/Resource/Processing/ImagePreviewTask.php+0 −3
- typo3/sysext/core/Classes/Resource/FileReference.php+0 −2
- typo3/sysext/core/Classes/Resource/InaccessibleFolder.php+14 −17
- typo3/sysext/core/Classes/Resource/ProcessedFile.php+0 −1
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+0 −4
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php+0 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/ControllerContext.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMap.php+0 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/PersistenceManager.php+1 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/Query.php+2 −3
- typo3/sysext/extbase/Classes/Property/TypeConverter/DateTimeConverter.php+1 −1
- typo3/sysext/extbase/Classes/Scheduler/FieldProvider.php+1 −1
- typo3/sysext/extensionmanager/Classes/Report/ExtensionStatus.php+1 −1
- typo3/sysext/filelist/Classes/Controller/FileListController.php+0 −2
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php+4 −0
- typo3/sysext/form/Classes/Domain/Configuration/FrameworkConfiguration/Extractors/ExtractorDto.php+3 −3
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+1 −1
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinitionConversionService.php+1 −0
- typo3/sysext/form/Classes/Domain/Finishers/SaveToDatabaseFinisher.php+2 −2
- typo3/sysext/form/Classes/ViewHelpers/RenderAllFormValuesViewHelper.php+1 −0
- typo3/sysext/frontend/Classes/ContentObject/Menu/CategoryMenuUtility.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/FilesContentObject.php2+0 −1
- typo3/sysext/frontend/Classes/Middleware/EidHandler.php+1 −0
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+0 −1
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+0 −2
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+1 −1
- typo3/sysext/indexed_search/Classes/Example/PluginHook.php+0 −1
- typo3/sysext/install/Classes/Command/UpgradeWizardCommand.php+3 −4
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+1 −0
- typo3/sysext/install/Classes/Http/RequestHandler.php+1 −1
- typo3/sysext/install/Classes/UpgradeAnalysis/DocumentationFile.php+1 −0
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+1 −1
- typo3/sysext/opendocs/Classes/Service/OpenDocumentService.php+1 −0
- typo3/sysext/rsaauth/Classes/Controller/RsaPublicKeyGenerationController.php+1 −0
- typo3/sysext/seo/Classes/XmlSitemap/RecordsXmlSitemapDataProvider.php+1 −0
- typo3/sysext/sys_action/Classes/ActionTask.php+1 −0
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+1 −1
Review log 1316
-
Wouter Wolters uploaded patch set 1 09/02/18, 16:05
-
Wouter Wolters updated the commit message in patch set 2 09/02/18, 16:09
-
TYPO3com voted on patch set 1 V +1 09/02/18, 16:15 Completed build in 10m 32s on Sun, 2 Sep, 06:15 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27566
-
TYPO3com voted on patch set 2 V +1 09/02/18, 16:23 Completed build in 12m 38s on Sun, 2 Sep, 06:23 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27568
-
Christian Kuhn commented on patch set 2 09/02/18, 16:45
-
Christian Kuhn voted on patch set 2 CR -1 09/02/18, 16:45
-
Christian Kuhn uploaded patch set 3 09/02/18, 16:52
-
Christian Kuhn commented on patch set 3 09/02/18, 16:52
removed a couple of @throws at places where the method itself does not throw directly. -
TYPO3com voted on patch set 3 V +1 09/02/18, 17:02 Completed build in 10m 06s on Sun, 2 Sep, 07:02 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27576
-
Christian Kuhn voted on patch set 3 V +1 CR +1 09/02/18, 17:26
-
Anja Leichsenring commented on patch set 3 09/02/18, 17:37
FilesContentObject.php:175that is no array -
Wouter Wolters commented on patch set 3 09/02/18, 17:40
FilesContentObject.php:175Reply Unresolvedthat is why the complete @return is removed ;) -
Frans Saris commented on patch set 3 09/03/18, 06:44
CropVariantCollection.php:157Should this be `@param CropVariant ...$cropVariants` ? Could directly find any documentation about this more then https://github.com/squizlabs/PHP_CodeSniffer/issues/841 -
Wouter Wolters commented on patch set 3 09/03/18, 06:51
CropVariantCollection.php:157Replyphpstorm doesn't recognize the ... -
Anja Leichsenring voted on patch set 3 V +2 CR +2 09/03/18, 08:59
-
Anja Leichsenring merged patch set 4 09/03/18, 08:59
AdminPanelDataPersister.php:41