Review main Merged

58129[TASK] Streamline PHPDoc comment matches function/method signature

Wouter Wolters CR +2 V +2 Normal +82 −87 updated 09/03/18, 08:59

Commit message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 59

Show 39 more files

Review log 1316

  1. Wouter Wolters uploaded patch set 1 09/02/18, 16:05

  2. Wouter Wolters updated the commit message in patch set 2 09/02/18, 16:09

  3. TYPO3com voted on patch set 1 V +1 09/02/18, 16:15 Completed build in 10m 32s on Sun, 2 Sep, 06:15 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27566

  4. TYPO3com voted on patch set 2 V +1 09/02/18, 16:23 Completed build in 12m 38s on Sun, 2 Sep, 06:23 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27568

  5. Christian Kuhn commented on patch set 2 09/02/18, 16:45

    AdminPanelDataPersister.php:41

    i still think it does not make sense to annotate @throws if the method itself does not throw the exception. we'd otherwise end up with "all" possible exceptions in most controllers / other high level entry points.
  6. Christian Kuhn voted on patch set 2 CR -1 09/02/18, 16:45

  7. Christian Kuhn uploaded patch set 3 09/02/18, 16:52

  8. Christian Kuhn commented on patch set 3 09/02/18, 16:52

    removed a couple of @throws at places where the method itself does not throw directly.
  9. TYPO3com voted on patch set 3 V +1 09/02/18, 17:02 Completed build in 10m 06s on Sun, 2 Sep, 07:02 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27576

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 09/02/18, 17:26

  11. Anja Leichsenring commented on patch set 3 09/02/18, 17:37

    FilesContentObject.php:175

    that is no array
  12. Wouter Wolters commented on patch set 3 09/02/18, 17:40

    FilesContentObject.php:175 Reply Unresolved

    that is why the complete @return is removed ;)
  13. Frans Saris commented on patch set 3 09/03/18, 06:44

    CropVariantCollection.php:157

    Should this be `@param CropVariant ...$cropVariants` ? Could directly find any documentation about this more then https://github.com/squizlabs/PHP_CodeSniffer/issues/841
  14. Wouter Wolters commented on patch set 3 09/03/18, 06:51

    CropVariantCollection.php:157 Reply

    phpstorm doesn't recognize the ...
  15. Anja Leichsenring voted on patch set 3 V +2 CR +2 09/03/18, 08:59

  16. Anja Leichsenring merged patch set 4 09/03/18, 08:59