Review main Merged

58131[TASK] Move documentation files into 9.4 folder - part 2

Anja Leichsenring CR +2 V +2 Hard +474 −385 updated 09/03/18, 09:05

Commit message

The change also contains some documentation related improvements
in some code files, where the need occured.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Björn Jacob +1
  • Verified V +2
    • Christian Kuhn +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 73

Show 53 more files

Review log 1519

  1. Anja Leichsenring uploaded patch set 1 09/02/18, 18:30

  2. TYPO3com voted on patch set 1 V +1 09/02/18, 18:40 Completed build in 10m 01s on Sun, 2 Sep, 08:40 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27585

  3. Björn Jacob commented on patch set 1 CR -1 09/02/18, 18:52

    Feature-84584-Re-DesignTheAdminPanel.rst:18

    Sentences like the one above?

    Feature-85691-ShowPagePathForReferencesInRecordInfo.rst:12

    Don't get this sentence.

    Feature-85719-AllowSitesWithoutSchemeOrDomain.rst:31

    "improved"?

    Feature-85828-MoveSymfonyExpressionLanguageHandlingIntoEXTcore.rst:13

    "Thus, "

    Feature-85947-PageBasedURLHandling.rst:35

    can be removed IMHO

    Feature-85947-PageBasedURLHandling.rst:36

    "Nonetheless, "

    Feature-85947-PageBasedURLHandling.rst:36

    "a proper"

    Feature-86051-ShowExtensionsViaCLI.rst:16

    can be removed IMHO
  4. Anja Leichsenring commented on patch set 1 09/02/18, 19:03

    Feature-84584-Re-DesignTheAdminPanel.rst:18 Reply

    Done

    Feature-85691-ShowPagePathForReferencesInRecordInfo.rst:12 Reply

    Done

    Feature-85719-AllowSitesWithoutSchemeOrDomain.rst:31 Reply

    Done

    Feature-85828-MoveSymfonyExpressionLanguageHandlingIntoEXTcore.rst:13 Reply

    Done

    Feature-85947-PageBasedURLHandling.rst:35 Reply

    Done

    Feature-85947-PageBasedURLHandling.rst:36 Reply

    Done

    Feature-85947-PageBasedURLHandling.rst:36 Reply

    Done

    Feature-86051-ShowExtensionsViaCLI.rst:16 Reply

    Done
  5. Anja Leichsenring uploaded patch set 2 09/02/18, 19:04

  6. Björn Jacob voted on patch set 2 V +1 CR +1 09/02/18, 19:05

  7. Anja Leichsenring commented on patch set 2 CR -1 09/02/18, 19:07

    render improvements in progress
  8. TYPO3com voted on patch set 2 V +1 09/02/18, 19:12 Completed build in 07m 34s on Sun, 2 Sep, 09:12 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27588

  9. Anja Leichsenring uploaded patch set 3 09/02/18, 20:04

  10. Anja Leichsenring commented on patch set 3 CR -1 09/02/18, 20:11

    render test not done yet. on it.
  11. TYPO3com voted on patch set 3 V +1 09/02/18, 20:13 Completed build in 08m 41s on Sun, 2 Sep, 10:13 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27594

  12. Anja Leichsenring uploaded patch set 4 09/02/18, 21:45

  13. TYPO3com voted on patch set 4 V +1 09/02/18, 21:56 Completed build in 10m 36s on Sun, 2 Sep, 11:56 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27598

  14. Christian Kuhn voted on patch set 4 V +1 CR +1 09/02/18, 22:47

  15. Björn Jacob commented on patch set 4 09/03/18, 05:28

    One minor thing I think.

    Feature-85719-AllowSitesWithoutSchemeOrDomain.rst:35

    List would be * not -
  16. Anja Leichsenring commented on patch set 4 09/03/18, 08:20

    Feature-85719-AllowSitesWithoutSchemeOrDomain.rst:35 Reply

    both works
  17. Björn Jacob voted on patch set 4 V +1 CR +1 09/03/18, 09:04

  18. Christian Kuhn voted on patch set 4 V +2 CR +2 09/03/18, 09:05

  19. Christian Kuhn merged patch set 5 09/03/18, 09:05