Review main Merged

58132[BUGFIX] Do not use empty needle in strpos in SimpleFileBackend

Jigal van Hemert CR +2 V +2 Easy +1 −1 updated 09/03/18, 08:33

Commit message

This only happens on Windows as the call is inside a condition
that tests for Windows OS.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Jigal van Hemert uploaded patch set 1 09/02/18, 21:34

  2. TYPO3com voted on patch set 1 V +1 09/02/18, 21:43 Completed build in 09m 35s on Sun, 2 Sep, 11:43 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27597

  3. Christian Kuhn updated the commit message in patch set 2 09/02/18, 22:48

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 09/02/18, 22:49

  5. TYPO3com voted on patch set 2 V +1 09/02/18, 22:59 Completed build in 10m 50s on Mon, 3 Sep, 12:59 AM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27601

  6. Andreas Kienast voted on patch set 2 CR +1 09/03/18, 06:21

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 09/03/18, 08:33

  8. Andreas Kienast merged patch set 3 09/03/18, 08:33