Review main Merged

58134[TASK] Set indexed_search set_id field from type=none to input readOnly

Christian Kuhn CR +2 V +2 Easy +2 −1 updated 09/03/18, 09:01

Commit message

The indexed_search_config field set_id can be easily switched from
type=none to type=input with readOnly=true. This is semantically
more correct since the field does have a db representation and
is just meant to be not editable.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 09/03/18, 01:43

  2. TYPO3com voted on patch set 1 V +1 09/03/18, 01:52 Completed build in 08m 56s on Mon, 3 Sep, 03:52 AM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27603

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 09/03/18, 08:48

  4. Wouter Wolters voted on patch set 1 CR +1 09/03/18, 08:52

  5. Anja Leichsenring voted on patch set 1 V +2 CR +2 09/03/18, 09:01

  6. Anja Leichsenring merged patch set 2 09/03/18, 09:01