Review main Merged

58135[TASK] Make type=passthrough a formEngine element

Christian Kuhn CR +2 V +2 Normal +51 −20 updated 09/03/18, 09:01

Commit message

To be more consistent and have one special case less,
type=passthrough columns are now casual elements that
go through the NodeFactory of FormEngine just as all
other types.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 68

  1. Christian Kuhn uploaded patch set 1 09/03/18, 02:46

  2. Christian Kuhn uploaded patch set 2 09/03/18, 02:47

  3. Christian Kuhn commented on patch set 2 09/03/18, 02:51

    styleguide master got a patch to verify this works well even for flex form fields.
  4. TYPO3com voted on patch set 1 V +1 09/03/18, 02:58 Completed build in 11m 51s on Mon, 3 Sep, 04:58 AM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27604

  5. TYPO3com voted on patch set 2 V +1 09/03/18, 03:01 Completed build in 11m 44s on Mon, 3 Sep, 05:01 AM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27605

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 09/03/18, 08:42

  7. Anja Leichsenring voted on patch set 2 V +2 CR +2 09/03/18, 09:01

  8. Anja Leichsenring merged patch set 3 09/03/18, 09:01