58140[TASK] Adjust LinkGeneratorTest for non-site scenario
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Andreas Wolf +2
- Christian Kuhn +1
-
Verified V +2
- Benni Mack +2
- Andreas Wolf +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/Routing/SiteMatcher.php+9 −3
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+3 −3
- typo3/sysext/frontend/Classes/DataProcessing/LanguageMenuProcessor.php+6 −6
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/SlugScenario.yaml+9 −9
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LinkGeneratorTest.php+199 −228
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php2+17 −4
Review log 1318
-
Oliver Hader uploaded patch set 1 09/03/18, 12:36
-
TYPO3com voted on patch set 1 V -1 09/03/18, 12:49 Completed build in 12m 41s on Mon, 3 Sep, 02:49 PM Test Summary: 63 of 36304 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27642
-
Oliver Hader uploaded patch set 2 09/03/18, 14:21
-
TYPO3com voted on patch set 2 V -1 09/03/18, 14:31 Completed build in 10m 14s on Mon, 3 Sep, 04:31 PM Test Summary: 3 of 36304 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27645
-
Oliver Hader uploaded patch set 3 09/03/18, 14:43
-
TYPO3com voted on patch set 3 V +1 09/03/18, 14:54 Completed build in 10m 25s on Mon, 3 Sep, 04:54 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27648
-
Benni Mack voted on patch set 3 V +1 CR +1 09/03/18, 14:55
-
Christian Kuhn voted on patch set 3 V +1 CR +1 09/03/18, 15:31
-
Andreas Wolf uploaded patch set 4 09/03/18, 15:34
-
Andreas Wolf commented on patch set 4 V +1 CR +1 09/03/18, 15:35
-
Oliver Hader commented on patch set 5 09/03/18, 15:36
Published edit on patch set 4. -
Oliver Hader commented on patch set 3 09/03/18, 15:39
SlugSiteRequestTest.php:255ReplyNope, that's https://forge.typo3.org/issues/86111 -
TYPO3com voted on patch set 4 V +1 09/03/18, 15:45 Completed build in 10m 52s on Mon, 3 Sep, 05:45 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27655
-
Christian Kuhn voted on patch set 5 V +1 CR +1 09/03/18, 15:45
-
TYPO3com voted on patch set 5 V +1 09/03/18, 15:47 Completed build in 11m 01s on Mon, 3 Sep, 05:47 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27656
-
Benni Mack voted on patch set 5 V +2 CR +2 09/03/18, 15:51
-
Benni Mack merged patch set 6 09/03/18, 15:51
-
Andreas Wolf voted on patch set 6 V +2 CR +2 09/03/18, 15:51
SlugSiteRequestTest.php:255