Review main Merged

58140[TASK] Adjust LinkGeneratorTest for non-site scenario

Oliver Hader CR +2 V +2 Hard +243 −253 updated 09/03/18, 15:51

Commit message

When using a Site according "slug" values have to be given in order to
have complete routing information. There won't be pages in sites that
explicitly have empty slugs.

Test cases for sites having slugs are available in
SlugLinkGeneratorTest.  In order to test legacy behavior without having
sites and slugs, the scenario of LinkGeneratorTest has been adjusted
accordingly.

Review

  • Code review CR +2
    • Benni Mack +2
    • Andreas Wolf +2
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Andreas Wolf +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1318

  1. Oliver Hader uploaded patch set 1 09/03/18, 12:36

  2. TYPO3com voted on patch set 1 V -1 09/03/18, 12:49 Completed build in 12m 41s on Mon, 3 Sep, 02:49 PM Test Summary: 63 of 36304 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27642

  3. Oliver Hader uploaded patch set 2 09/03/18, 14:21

  4. TYPO3com voted on patch set 2 V -1 09/03/18, 14:31 Completed build in 10m 14s on Mon, 3 Sep, 04:31 PM Test Summary: 3 of 36304 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27645

  5. Oliver Hader uploaded patch set 3 09/03/18, 14:43

  6. TYPO3com voted on patch set 3 V +1 09/03/18, 14:54 Completed build in 10m 25s on Mon, 3 Sep, 04:54 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27648

  7. Benni Mack voted on patch set 3 V +1 CR +1 09/03/18, 14:55

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 09/03/18, 15:31

  9. Andreas Wolf uploaded patch set 4 09/03/18, 15:34

  10. Andreas Wolf commented on patch set 4 V +1 CR +1 09/03/18, 15:35

    SlugSiteRequestTest.php:255

    is this TODO not solvable atm?
  11. Oliver Hader commented on patch set 5 09/03/18, 15:36

    Published edit on patch set 4.
  12. Oliver Hader commented on patch set 3 09/03/18, 15:39

    SlugSiteRequestTest.php:255 Reply

  13. TYPO3com voted on patch set 4 V +1 09/03/18, 15:45 Completed build in 10m 52s on Mon, 3 Sep, 05:45 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27655

  14. Christian Kuhn voted on patch set 5 V +1 CR +1 09/03/18, 15:45

  15. TYPO3com voted on patch set 5 V +1 09/03/18, 15:47 Completed build in 11m 01s on Mon, 3 Sep, 05:47 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27656

  16. Benni Mack voted on patch set 5 V +2 CR +2 09/03/18, 15:51

  17. Benni Mack merged patch set 6 09/03/18, 15:51

  18. Andreas Wolf voted on patch set 6 V +2 CR +2 09/03/18, 15:51