Review main Merged

58143[BUGFIX] Suffix all interfaces with Interface

Benni Mack CR +2 V +2 Easy +5 −5 updated 09/03/18, 16:47

Commit message

The patch introducing interfaces for upgrade wizards had some mixed
namings, which are now corrected.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Susi Moog +1
  • Verified V +2
    • Andreas Kienast +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 911

  1. Benni Mack uploaded patch set 1 09/03/18, 15:54

  2. TYPO3com voted on patch set 1 V +1 09/03/18, 16:16 Completed build in 18m 14s on Mon, 3 Sep, 06:16 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27662

  3. Susi Moog commented on patch set 1 CR -1 09/03/18, 16:33

    DatabaseUpdatedPrerequisiteInterface.php:27

    this is not an interface.
  4. Susi Moog commented on patch set 1 09/03/18, 16:33

    MigratePagesLanguageOverlayBeGroupsAccessRights.php:116

    this is no interface.
  5. Susi Moog uploaded patch set 2 09/03/18, 16:37

  6. Susi Moog voted on patch set 2 V +1 CR +1 09/03/18, 16:39

  7. Christian Kuhn voted on patch set 2 CR +1 09/03/18, 16:43

  8. Andreas Kienast commented on patch set 2 CR +2 09/03/18, 16:43

    Waiting for bamboo
  9. TYPO3com voted on patch set 2 V +1 09/03/18, 16:46 Completed build in 09m 22s on Mon, 3 Sep, 06:46 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27670

  10. Andreas Kienast voted on patch set 2 V +2 09/03/18, 16:47

  11. Andreas Kienast merged patch set 3 09/03/18, 16:47