Review main Merged

58144[BUGFIX] Avoid suffixing base slug again

Oliver Hader CR +2 V +2 Easy +19 −2 updated 09/03/18, 17:48

Commit message

When invoking slug generation on an empty or base slug (`/`), the
slug will become `//` - which is invalid and has to be avoided.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Andreas Kienast +1
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2
    • Oliver Hader +2
    • Andreas Kienast +1
    • Susi Moog +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1013

  1. Oliver Hader uploaded patch set 1 09/03/18, 16:52

  2. Benni Mack commented on patch set 1 09/03/18, 16:54

    looks good
  3. Oliver Hader updated the commit message in patch set 2 09/03/18, 16:57

  4. TYPO3com voted on patch set 1 V +1 09/03/18, 17:03 Completed build in 10m 55s on Mon, 3 Sep, 07:03 PM Test Summary: 35962 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27672

  5. Oliver Hader uploaded patch set 3 09/03/18, 17:08

  6. TYPO3com voted on patch set 2 V +1 09/03/18, 17:15 Completed build in 16m 25s on Mon, 3 Sep, 07:15 PM Test Summary: 35962 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27675

  7. TYPO3com voted on patch set 3 V +1 09/03/18, 17:25 Completed build in 16m 52s on Mon, 3 Sep, 07:25 PM Test Summary: 35965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27677

  8. Benni Mack voted on patch set 3 V +1 CR +1 09/03/18, 17:26

  9. Andreas Kienast voted on patch set 3 CR +1 09/03/18, 17:38

  10. Susi Moog voted on patch set 3 V +1 CR +1 09/03/18, 17:40

  11. Andreas Kienast voted on patch set 3 V +1 09/03/18, 17:42

  12. Oliver Hader voted on patch set 3 V +2 CR +2 09/03/18, 17:48

  13. Oliver Hader merged patch set 4 09/03/18, 17:48