Review main Merged

58145[BUGFIX] Only unlock records in BE user log off functionality

Benni Mack CR +2 V +2 Easy +18 −3 updated 09/03/18, 17:53

Commit message

The database table `sys_lockedrecords` should only be cleared via
the BackendUtility when a Backend user is logging off. Currently, this
is also called for Frontend Users, which actually removes everything
from the currently logged-in backend users with the same uid.

As this is very bad code design on many levels (lockRecords for
unlocking, no context for the authentication user object etc), this
should be encapsulated within the BackendUser object directly anyway.

For further abstractions, this could also be a hook or something else,
to be even cleaner.

Review

  • Code review CR +2
    • Markus Klein +2
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2
    • Markus Klein +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1317

  1. Benni Mack uploaded patch set 1 09/03/18, 16:53

  2. Benni Mack updated the commit message in patch set 2 09/03/18, 16:55

  3. TYPO3com voted on patch set 1 V +1 09/03/18, 17:09 Completed build in 14m 38s on Mon, 3 Sep, 07:09 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27673

  4. TYPO3com voted on patch set 2 V +1 09/03/18, 17:13 Completed build in 14m 44s on Mon, 3 Sep, 07:13 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27674

  5. Markus Klein commented on patch set 2 09/03/18, 17:31

    a db table can't be "called"
  6. Markus Klein updated the commit message in patch set 3 09/03/18, 17:35

  7. Markus Klein voted on patch set 3 V +1 CR +1 09/03/18, 17:35

  8. Markus Klein commented on patch set 3 09/03/18, 17:37

    Should be backport that to v8 (and even v7)?
  9. Benni Mack commented on patch set 3 09/03/18, 17:37

    dunno, nobody cared until now. Just found this by looking at the code. Does not seem to be critical
  10. Markus Klein commented on patch set 3 09/03/18, 17:39

    Not critical because rather an edge case. I still suggest the v8 backport because it's easy
  11. Benni Mack updated the commit message in patch set 4 09/03/18, 17:40

  12. Oliver Hader voted on patch set 4 CR +1 09/03/18, 17:43

  13. Andreas Kienast voted on patch set 4 V +1 CR +1 09/03/18, 17:45

  14. TYPO3com voted on patch set 3 V +1 09/03/18, 17:47 Completed build in 11m 52s on Mon, 3 Sep, 07:47 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27680

  15. TYPO3com voted on patch set 4 V +1 09/03/18, 17:50 Completed build in 10m 01s on Mon, 3 Sep, 07:50 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27682

  16. Markus Klein voted on patch set 4 V +2 CR +2 09/03/18, 17:53

  17. Markus Klein merged patch set 5 09/03/18, 17:53