Review main Merged

58146[BUGFIX] Avoid database upgrade failures when adding slug field

Oliver Hader CR +2 V +2 Easy +1 −1 updated 09/03/18, 19:29

Commit message

When upgrading with e.g. MSSQL it should be noted, that the
pages.slug DB field should be a varchar database field (instead of
"text"), which can be null, allowing the field to be created when
upgrading an instance, without having the upgrade wizard run yet.

So all slug fields are set to null, and can be ommitted correctly.

Review

  • Code review CR +2
    • Susi Moog +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1317

  1. Oliver Hader uploaded patch set 1 09/03/18, 17:20

  2. TYPO3com voted on patch set 1 V +1 09/03/18, 17:31 Completed build in 11m 30s on Mon, 3 Sep, 07:31 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27678

  3. Benni Mack updated the commit message in patch set 2 09/03/18, 18:31

  4. Benni Mack voted on patch set 2 CR +1 09/03/18, 18:39

  5. TYPO3com voted on patch set 2 V +1 09/03/18, 18:46 Completed build in 14m 50s on Mon, 3 Sep, 08:46 PM Test Summary: 35965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27690

  6. Susi Moog commented on patch set 2 CR -1 09/03/18, 18:47

    commit message states "can be null", ext_tables states "NOT NULL"
  7. Benni Mack commented on patch set 3 09/03/18, 18:50

    Published edit on patch set 2.
  8. Benni Mack updated the commit message in patch set 4 09/03/18, 18:51

  9. Susi Moog voted on patch set 3 CR +1 09/03/18, 18:51

  10. Susi Moog voted on patch set 4 CR +1 09/03/18, 18:52

  11. TYPO3com voted on patch set 3 V +1 09/03/18, 19:04 Completed build in 12m 41s on Mon, 3 Sep, 09:04 PM Test Summary: 35965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27693

  12. TYPO3com voted on patch set 4 V +1 09/03/18, 19:08 Completed build in 16m 39s on Mon, 3 Sep, 09:08 PM Test Summary: 35965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27694

  13. Benni Mack voted on patch set 4 V +1 CR +1 09/03/18, 19:15

  14. Andreas Kienast voted on patch set 4 CR +1 09/03/18, 19:27

  15. Susi Moog voted on patch set 4 V +1 09/03/18, 19:29

  16. Susi Moog voted on patch set 4 V +2 CR +2 09/03/18, 19:29

  17. Susi Moog merged patch set 5 09/03/18, 19:29