Review TYPO3_8-7 Merged

58148[BUGFIX] Only unlock records in BE user log off functionality

Markus Klein CR +2 V +2 Easy +18 −3 updated 09/03/18, 21:35

Commit message

The database table `sys_lockedrecords` should only be cleared via
the BackendUtility when a Backend user is logging off. Currently, this
is also called for Frontend Users, which actually removes everything
from the currently logged-in backend users with the same uid.

As this is very bad code design on many levels (lockRecords for
unlocking, no context for the authentication user object etc), this
should be encapsulated within the BackendUser object directly anyway.

For further abstractions, this could also be a hook or something else,
to be even cleaner.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 46

  1. Markus Klein uploaded patch set 1 09/03/18, 17:57

  2. TYPO3com voted on patch set 1 V -1 09/03/18, 17:58 Completed build in 14s on Mon, 3 Sep, 07:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2914

  3. Markus Klein uploaded patch set 2 09/03/18, 18:01

  4. TYPO3com voted on patch set 2 V +1 09/03/18, 18:09 Completed build in 08m 21s on Mon, 3 Sep, 08:09 PM Test Summary: 59428 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2915

  5. Markus Klein voted on patch set 2 V +2 CR +2 09/03/18, 21:35

  6. Markus Klein merged patch set 3 09/03/18, 21:35