Review main Merged

58150[TASK] Ensure version placeholders get updated on slug changes

Oliver Hader CR +2 V +2 Easy +2 −1 updated 09/03/18, 21:02

Commit message

This change ensures that workspace version placeholders are kept
in sync when slug values (TCA type 'slug') are modified in their
specific workspace version. This is done implicitly without the
requirement to define shadowColumnsForNewPlaceholders in TCA.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +2
    • Andreas Kienast +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1619

  1. Oliver Hader uploaded patch set 1 09/03/18, 18:50

  2. Wouter Wolters voted on patch set 1 CR +1 09/03/18, 18:53

  3. TYPO3com voted on patch set 1 V -1 09/03/18, 19:03 Completed build in 12m 35s on Mon, 3 Sep, 09:03 PM Test Summary: 2085 of 36313 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27692

  4. TYPO3com commented on patch set 1 09/03/18, 19:19 Completed build in 41m 06s on Mon, 3 Sep, 09:19 PM Test Summary: 2692 of 36313 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27692

  5. Susi Moog commented on patch set 1 09/03/18, 19:29

    DataHandler.php:720

    you are not calling the constructor in tests, which results in the errors...
  6. Oliver Hader commented on patch set 1 09/03/18, 20:06

    Well, I don't call any tests here at all... that's obviously the drawback of those tests...
  7. Oliver Hader uploaded patch set 2 09/03/18, 20:08

  8. TYPO3com voted on patch set 2 V +1 09/03/18, 20:33 Completed build in 16m 59s on Mon, 3 Sep, 10:33 PM Test Summary: 35977 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27716

  9. Andreas Kienast voted on patch set 2 V +1 CR +1 09/03/18, 20:39

  10. Georg Ringer voted on patch set 2 CR +1 09/03/18, 20:43

  11. Wouter Wolters voted on patch set 2 CR +1 09/03/18, 20:44

  12. Susi Moog commented on patch set 2 09/03/18, 20:47

    > (1 comment) what I meant was: the tests expect the instance to be instanciated outside of the constructor else the mocking won't work. but you got it... anyway.
  13. Benni Mack voted on patch set 2 CR +2 09/03/18, 20:51

  14. Christian Kuhn voted on patch set 2 CR +1 09/03/18, 20:52

  15. Christian Kuhn commented on patch set 2 09/03/18, 20:52

    testing ...
  16. Susi Moog voted on patch set 2 V +1 CR +1 09/03/18, 21:00

  17. Christian Kuhn voted on patch set 2 V +2 CR +2 09/03/18, 21:02

  18. Christian Kuhn merged patch set 3 09/03/18, 21:02

  19. Benni Mack voted on patch set 3 V +2 09/03/18, 21:02