Review main Merged

58152[BUGFIX] Cast return value of getLivePageUid to int

Susi Moog CR +2 V +2 Easy +1 −1 updated 09/03/18, 19:57

Commit message

On database systems like sqlite fields like uid or
t3ver_oid are returned as string and need to be casted.

This casting has been added in PreviewUriBuilder
->getLivePageUid.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Wouter Wolters +1
    • Richard Haeser +1
    • Benni Mack +1
  • Verified V +2
    • Oliver Hader +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Susi Moog uploaded patch set 1 09/03/18, 19:04

  2. Wouter Wolters voted on patch set 1 CR +1 09/03/18, 19:05

  3. Richard Haeser voted on patch set 1 CR +1 09/03/18, 19:05

  4. Oliver Hader voted on patch set 1 V +2 CR +2 09/03/18, 19:12

  5. TYPO3com voted on patch set 1 V +1 09/03/18, 19:21 Completed build in 16m 19s on Mon, 3 Sep, 09:21 PM Test Summary: 35965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27697

  6. Benni Mack merged patch set 2 09/03/18, 19:57

  7. Benni Mack voted on patch set 2 V +1 CR +1 09/03/18, 19:57