Review main Merged

58153[BUGFIX] Ensure slug update wizard uses proper sorting

Benni Mack CR +2 V +2 Easy +5 −0 updated 09/03/18, 21:04

Commit message

If two subpages share the same name, it is important, that the first
page gets a proper name, and the second one follows the uniqueInSite pattern.

Also, sorting by workspaces (live first), PID and then sorting seems to be
just logical. I wonder why I did not add this before.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Benni Mack uploaded patch set 1 09/03/18, 19:06

  2. TYPO3com voted on patch set 1 V +1 09/03/18, 19:25 Completed build in 12m 43s on Mon, 3 Sep, 09:25 PM Test Summary: 35965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27698

  3. Christian Kuhn commented on patch set 1 CR -1 09/03/18, 20:18

    on it. testing.
  4. Christian Kuhn voted on patch set 1 V +1 CR +1 09/03/18, 20:21

  5. Wouter Wolters voted on patch set 1 CR +1 09/03/18, 20:26

  6. Andreas Kienast commented on patch set 1 V -1 09/03/18, 20:30

    Temp -1: I have two pages called "foo" in the live workspace and a third "foo" page in my test workspace, all of them in the same level. One page of live and the workspace page share the same slug now. This is not intended, is it?
  7. Andreas Kienast commented on patch set 1 09/03/18, 20:36

    I made a screenshot: https://i.imgur.com/AzvPKUJ.png
  8. Andreas Kienast commented on patch set 1 09/03/18, 20:39

    Having also https://review.typo3.org/c/58150/ applied solves the issue for me
  9. Andreas Kienast voted on patch set 1 V +2 CR +2 09/03/18, 21:03

  10. Andreas Kienast merged patch set 2 09/03/18, 21:04