Review main Merged

58155[BUGFIX] Auto-generate slug when invalid characters are given

Benni Mack CR +2 V +2 Normal +49 −2 updated 09/03/18, 19:59

Commit message

If a page title is like "!!!" this currently results in an invalid slug.

The generator now auto-generates something with "default-hashXYZ"
in order to always be unique on creation time.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 09/03/18, 19:15

  2. Wouter Wolters voted on patch set 1 CR +1 09/03/18, 19:19

  3. TYPO3com voted on patch set 1 V +1 09/03/18, 19:34 Completed build in 16m 53s on Mon, 3 Sep, 09:34 PM Test Summary: 35977 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27700

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 09/03/18, 19:54

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 09/03/18, 19:56

  6. Christian Kuhn merged patch set 2 09/03/18, 19:59