Review main Merged

58165[BUGFIX] use gmmktime in checkConditionMatcherForDateFunction unit test

Jigal van Hemert CR +2 V +2 Easy +1 −1 updated 09/03/18, 21:20

Commit message

The arguments are now treated as parts of a UTC date/time and
prevents different results depending on the system date.timezone
settings.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2
    • Georg Ringer +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Jigal van Hemert uploaded patch set 1 09/03/18, 20:58

  2. Susi Moog voted on patch set 1 CR +1 09/03/18, 21:03

  3. Andreas Kienast voted on patch set 1 CR +1 09/03/18, 21:10

  4. TYPO3com voted on patch set 1 V +1 09/03/18, 21:12 Completed build in 12m 49s on Mon, 3 Sep, 11:12 PM Test Summary: 35977 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27726

  5. Susi Moog voted on patch set 1 V +1 09/03/18, 21:14

  6. Georg Ringer voted on patch set 1 V +2 CR +2 09/03/18, 21:20

  7. Georg Ringer merged patch set 2 09/03/18, 21:20