Review main Merged

58166[TASK] Move documentation files into 9.4 folder - part 3

Anja Leichsenring CR +2 V +2 Hard +209 −210 updated 09/04/18, 09:50

Commit message

The change also contains some documentation related improvements
in some code files, where the need occured.

Review

  • Code review CR +2
    • Susi Moog +2
    • Christian Kuhn +1
  • Verified V +2
    • Susi Moog +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 14

Review log 1319

  1. Anja Leichsenring uploaded patch set 1 09/03/18, 21:08

  2. TYPO3com voted on patch set 1 V +1 09/03/18, 21:25 Completed build in 13m 45s on Mon, 3 Sep, 11:25 PM Test Summary: 35977 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27729

  3. Anja Leichsenring updated the commit message in patch set 2 09/04/18, 08:14

  4. TYPO3com voted on patch set 2 V +1 09/04/18, 08:25 Completed build in 10m 19s on Tue, 4 Sep, 10:25 AM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27744

  5. Björn Jacob commented on patch set 2 CR -1 09/04/18, 08:29

    Feature-84525-XMLSitemap.rst:18

    Normally, we have to empty lines before headlines.

    Feature-84525-XMLSitemap.rst:21

    Maybe write in "" -> "XML Sitemap (seo)"

    Feature-84525-XMLSitemap.rst:28

    opening / calling?
  6. Anja Leichsenring commented on patch set 2 CR -1 09/04/18, 08:35

    I start another test render job to make sure the syntax is right.

    Feature-84525-XMLSitemap.rst:18 Reply

    thats only necessary when there was a codeblock or something like this.

    Feature-84525-XMLSitemap.rst:21 Reply

    Done

    Feature-84525-XMLSitemap.rst:28 Reply

    Done
  7. Anja Leichsenring uploaded patch set 3 09/04/18, 09:11

  8. Anja Leichsenring uploaded patch set 4 09/04/18, 09:12

  9. Anja Leichsenring commented on patch set 4 09/04/18, 09:14

    fixed some render warnings along the way, too
  10. Anja Leichsenring uploaded patch set 5 09/04/18, 09:20

  11. TYPO3com voted on patch set 3 V +1 09/04/18, 09:22 Completed build in 11m 07s on Tue, 4 Sep, 11:22 AM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27746

  12. Anja Leichsenring uploaded patch set 6 09/04/18, 09:24

  13. TYPO3com voted on patch set 4 V +1 09/04/18, 09:25 Completed build in 13m 09s on Tue, 4 Sep, 11:25 AM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27747

  14. TYPO3com voted on patch set 5 V +1 09/04/18, 09:33 Completed build in 12m 54s on Tue, 4 Sep, 11:33 AM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27749

  15. Christian Kuhn voted on patch set 6 V +1 CR +1 09/04/18, 09:36

  16. TYPO3com voted on patch set 6 V +1 09/04/18, 09:38 Completed build in 12m 34s on Tue, 4 Sep, 11:38 AM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27750

  17. Susi Moog voted on patch set 6 V +1 CR +1 09/04/18, 09:50

  18. Susi Moog voted on patch set 6 V +2 CR +2 09/04/18, 09:50

  19. Susi Moog merged patch set 7 09/04/18, 09:50