Review main Merged

58174[BUGFIX] Allow getPagesTSconfig to be called without BE_USER

Benni Mack CR +2 V +2 Normal +51 −7 updated 09/04/18, 08:03

Commit message

Due to refactorings lately in BackendUtility::getPagesTSconfig() with
which results in a fatal error when clearing page cache while persisting an
extbase object.

The patch adds a test without a Backend User, and encapsulates this
with a simple if() statement. However, this also shows that some
other areas that are touched are not fully notice-free / strict, which
are tackled as well.

Review

  • Code review CR +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Andreas Kienast +1
    • Oliver Hader +1
    • Susi Moog +1
  • Verified V +2
    • Markus Klein +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 89

  1. Benni Mack uploaded patch set 1 09/04/18, 07:08

  2. Andreas Kienast voted on patch set 1 CR +1 09/04/18, 07:11

  3. TYPO3com voted on patch set 1 V +1 09/04/18, 07:18 Completed build in 09m 29s on Tue, 4 Sep, 09:18 AM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27740

  4. Oliver Hader voted on patch set 1 CR +1 09/04/18, 07:20

  5. Susi Moog voted on patch set 1 CR +1 09/04/18, 07:45

  6. Daniel Goerz voted on patch set 1 CR +1 09/04/18, 07:46

  7. Susi Moog voted on patch set 1 V +1 09/04/18, 07:49

  8. Markus Klein commented on patch set 1 V +2 CR +2 09/04/18, 08:03

    played around a bit found no issues so far
  9. Markus Klein merged patch set 2 09/04/18, 08:03