Review main Merged

58178[BUGFIX] Resolve version move placeholder in RootlineUtility

Oliver Hader CR +2 V +2 Normal +121 −2 updated 09/04/18, 10:56

Commit message

In order to correctly work with rootlines (e.g. when resolving
according sites and pseudo-sites for URL resolving and generation)
possible version move placeholders have to be resolved.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1216

  1. Oliver Hader uploaded patch set 1 09/04/18, 10:06

  2. TYPO3com voted on patch set 1 V -1 09/04/18, 10:17 Completed build in 10m 49s on Tue, 4 Sep, 12:17 PM Test Summary: 6 of 36328 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27753

  3. Christian Kuhn voted on patch set 1 V +1 09/04/18, 10:21

  4. Christian Kuhn commented on patch set 1 V -1 CR -1 09/04/18, 10:32

    will push update
  5. Christian Kuhn uploaded patch set 2 09/04/18, 10:39

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 09/04/18, 10:39

  7. TYPO3com voted on patch set 2 V -1 09/04/18, 10:39 Completed build in 12s on Tue, 4 Sep, 12:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27756

  8. Christian Kuhn uploaded patch set 3 09/04/18, 10:39

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 09/04/18, 10:40

  10. Oliver Hader uploaded patch set 4 09/04/18, 10:44

  11. Susi Moog voted on patch set 4 V +1 CR +1 09/04/18, 10:46

  12. TYPO3com voted on patch set 3 V +1 09/04/18, 10:49 Completed build in 09m 24s on Tue, 4 Sep, 12:49 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27757

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 09/04/18, 10:53

  14. TYPO3com voted on patch set 4 V +1 09/04/18, 10:54 Completed build in 09m 19s on Tue, 4 Sep, 12:54 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27758

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 09/04/18, 10:56

  16. Christian Kuhn merged patch set 5 09/04/18, 10:56