Review main Abandoned

58179[BUGFIX] Always respect ?id parameter before URI

Benni Mack CR 0 V 0 Normal +38 −31 updated 09/30/18, 21:52

Commit message

Having two Pseudo-Sites, one without a sys_domain record,
and one with a sys_domain record like 'www.example.com',
does not allow to e.g. preview a page via
"www.example.com/index.php?id=rootid-of-first-page-id"

This makes it impossible to preview any page when logged
in to a backend domain and previewing.

In order to overcome this, the ?id= parameter is not just
evaluted against Sites but also Pseudo Sites, BEFORE
checks against sys_domain records or other routing
logic is used.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 13

Review log 68

  1. Benni Mack uploaded patch set 1 09/04/18, 10:10

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 09/04/18, 10:14

  3. Andreas Kienast commented on patch set 1 V -1 CR 0 09/04/18, 10:15

    Hmpf, functional tests will fail
  4. Benni Mack commented on patch set 1 09/04/18, 10:15

    I know :)
  5. TYPO3com voted on patch set 1 V -1 09/04/18, 10:20 Completed build in 09m 50s on Tue, 4 Sep, 12:20 PM Test Summary: 99 of 36328 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27754

  6. Andreas Kienast uploaded patch set 2 09/14/18, 15:12

  7. TYPO3com voted on patch set 2 V -1 09/14/18, 15:20 Completed build in 08m 16s on Fri, 14 Sep, 05:20 PM Test Summary: 54 of 36253 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28099

  8. Benni Mack abandoned the change 09/30/18, 21:52