58182[TASK] Rework pseudo-site backend preview url generation
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Georg Ringer +1
- Andreas Kienast +1
- Susi Moog +1
-
Verified V +2
- Anja Leichsenring +2
- Georg Ringer +1
- Andreas Kienast +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1216
-
Benjamin Franzke uploaded patch set 1 09/04/18, 12:19
-
TYPO3com voted on patch set 1 V -1 09/04/18, 12:19 Completed build in 09s on Tue, 4 Sep, 02:19 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27766
-
Benjamin Franzke commented on patch set 1 09/04/18, 12:26
Ok, seems this was fixed by https://review.typo3.org/c/58177/ in the meantime. Still I think this this version might be a bit better due tue not relying on an additional parse_url(). Will push a rebased variant marked as [TASK] -
Benjamin Franzke uploaded patch set 2 09/04/18, 12:29
-
Benjamin Franzke updated the commit message in patch set 3 09/04/18, 12:45
-
TYPO3com voted on patch set 2 V +1 09/04/18, 12:49 Completed build in 18m 23s on Tue, 4 Sep, 02:49 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27770
-
TYPO3com voted on patch set 3 V +1 09/04/18, 12:55 Completed build in 10m 03s on Tue, 4 Sep, 02:55 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27772
-
Andreas Kienast voted on patch set 3 V +1 CR +1 09/07/18, 16:48
-
Susi Moog updated the commit message in patch set 4 09/07/18, 16:51
-
TYPO3com voted on patch set 4 V +1 09/07/18, 17:03 Completed build in 12m 12s on Fri, 7 Sep, 07:03 PM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27876
-
Susi Moog voted on patch set 4 CR +1 09/07/18, 18:55
-
Georg Ringer voted on patch set 4 V +1 CR +1 09/07/18, 18:58
-
Susi Moog voted on patch set 4 V +1 09/07/18, 18:59
-
Andreas Kienast voted on patch set 4 V +1 CR +1 09/07/18, 19:03
-
Anja Leichsenring voted on patch set 4 V +2 CR +2 09/07/18, 19:03
-
Anja Leichsenring merged patch set 5 09/07/18, 19:03