Review main Merged

58186[BUGFIX] Add missing language file for ContextMenu

Stefan Froemken CR +2 V +2 Easy +1 −0 updated 09/18/18, 15:34

Commit message

Confirmation Modal shows buttons with translated button labels now, if
you try to delete a page from page-tree.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Guido Schmechel +1
    • Jörg Bösche +1
  • Verified V +2
    • Christian Kuhn +2
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Stefan Froemken uploaded patch set 1 09/04/18, 15:05

  2. TYPO3com voted on patch set 1 V +1 09/04/18, 15:13 Completed build in 07m 55s on Tue, 4 Sep, 05:13 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27779

  3. Christian Kuhn commented on patch set 1 CR -1 09/04/18, 15:14

    BackendController.php:172

    extension lang does not exist in master.
  4. Stefan Froemken uploaded patch set 2 09/04/18, 16:44

  5. Stefan Froemken commented on patch set 2 09/04/18, 16:46

    Interesting. It works with "lang". Seems that you have some really nasty mapping stuff somewhere in core ;-)
  6. TYPO3com voted on patch set 2 V +1 09/04/18, 16:54 Completed build in 09m 33s on Tue, 4 Sep, 06:54 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27780

  7. Wouter Wolters commented on patch set 2 CR +1 09/04/18, 17:18

    That is not "nasty" Stefan, that is a nice BC layer we have in place :)
  8. Guido Schmechel commented on patch set 2 V +1 CR +1 09/04/18, 21:51

    See also my comment for the delete button. Maybe we can handle both in this patch? If not: Patch works for the context menu (9.5-dev)
  9. Jörg Bösche voted on patch set 2 CR +1 09/18/18, 06:54

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 09/18/18, 15:34

  11. Christian Kuhn merged patch set 3 09/18/18, 15:34