Review main Merged

58190[TASK] Deprecate second controller action argument

Christian Kuhn CR +2 V +2 Normal +132 −13 updated 09/08/18, 12:29

Commit message

Core eid and backend dispatching uses only the $request object as
argument, but not the prepared $response object anymore. This was
a misconception in the first place.

The patch deprecates the second argument and logs deprecations
by reflecting the target action at runtime. This can be supressed
with a new feature toggle.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Benni Mack +1
  • Verified V +2
    • Anja Leichsenring +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1014

  1. Christian Kuhn uploaded patch set 1 09/05/18, 12:51

  2. Christian Kuhn uploaded patch set 2 09/05/18, 12:53

  3. TYPO3com voted on patch set 1 V -1 09/05/18, 13:02 Completed build in 11m 00s on Wed, 5 Sep, 03:02 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27797

  4. TYPO3com voted on patch set 2 V +1 09/05/18, 13:05 Completed build in 11m 37s on Wed, 5 Sep, 03:05 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27798

  5. Christian Kuhn uploaded patch set 3 09/07/18, 16:56

  6. Christian Kuhn commented on patch set 3 09/07/18, 16:56

    rebased
  7. TYPO3com voted on patch set 3 V +1 09/07/18, 17:09 Completed build in 12m 14s on Fri, 7 Sep, 07:09 PM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27878

  8. Benni Mack voted on patch set 3 CR +1 09/07/18, 17:59

  9. Christian Kuhn uploaded patch set 4 09/07/18, 22:48

  10. Benni Mack commented on patch set 4 V +1 CR +1 09/07/18, 22:50

    FactoryConfiguration should have this option on by deefault?
  11. TYPO3com voted on patch set 4 V +1 09/07/18, 22:57 Completed build in 09m 21s on Sat, 8 Sep, 12:57 AM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27892

  12. Christian Kuhn commented on patch set 4 09/08/18, 08:20

    unsure about factory configuration. this could go wrong if you install a new typo3 and then load some ext that needs it. would fatal then.
  13. Anja Leichsenring voted on patch set 4 V +2 CR +2 09/08/18, 12:29

  14. Anja Leichsenring merged patch set 5 09/08/18, 12:29