Review main Merged

58191[BUGFIX] Only add pages to XML sitemap with no_index = 0

Richard Haeser CR +2 V +2 Easy +1 −1 updated 09/05/18, 14:38

Commit message

Pages with no_index, follow shouldn't show up in XML sitemap. Only pages
that needs to be indexed.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Björn Jacob +1
    • Willi Wehmeier +1
  • Verified V +2
    • Anja Leichsenring +2
    • Björn Jacob +1

Issues 1

Files 1

Review log 67

  1. Richard Haeser uploaded patch set 1 09/05/18, 14:27

  2. Björn Jacob voted on patch set 1 V +1 CR +1 09/05/18, 14:30

  3. Willi Wehmeier voted on patch set 1 CR +1 09/05/18, 14:32

  4. Anja Leichsenring voted on patch set 1 V +2 CR +2 09/05/18, 14:34

  5. Anja Leichsenring merged patch set 2 09/05/18, 14:34

  6. Tobias Wollender commented on patch set 2 09/05/18, 14:37

    With this configuration, also subpages of a no_index page aren't included in the sitemap - even if the subpages should be indexed. Can this be considered here?
  7. TYPO3com voted on patch set 1 V +1 09/05/18, 14:38 Completed build in 10m 02s on Wed, 5 Sep, 04:38 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27800