58195[FEATURE] Use language service for TCA default value
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 1318
-
Guido Schmechel uploaded patch set 1 09/05/18, 21:07
-
TYPO3com voted on patch set 1 V +1 09/05/18, 21:15 Completed build in 07m 49s on Wed, 5 Sep, 11:15 PM Test Summary: 35983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27808
-
Mathias Brodala commented on patch set 1 CR -1 09/06/18, 07:16
As discussed in Slack please make this a master-only FEATURE instead including RST. -
Guido Schmechel uploaded patch set 2 09/06/18, 20:22
-
TYPO3com voted on patch set 2 V +1 09/06/18, 20:32 Completed build in 10m 18s on Thu, 6 Sep, 10:32 PM Test Summary: 35983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27828
-
Mathias Brodala commented on patch set 3 09/07/18, 07:27
Published edit on patch set 2. -
Mathias Brodala commented on patch set 3 09/07/18, 07:28
Updated RST, ee https://docs.typo3.org/typo3cms/drafts/github/TYPO3-Documentation/t3SphinxThemeRtdDemoDocs/Sitemap/Index.html for examples. -
Mathias Brodala commented on patch set 3 CR -1 09/07/18, 07:29
Looking good, only tiny nitpicks. ;-)DatabaseRowDefaultValues.php:66This needs a (string) cast, otherwise we'll get notices/errors e.g. for integer values.DatabaseRowDefaultValues.php:66This should be !empty()DatabaseRowDefaultValues.php:79Please add a return type hint here. -
TYPO3com voted on patch set 3 V +1 09/07/18, 07:37 Completed build in 09m 41s on Fri, 7 Sep, 09:37 AM Test Summary: 35983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27829
-
Guido Schmechel uploaded patch set 4 09/08/18, 19:43
-
Guido Schmechel commented on patch set 4 09/08/18, 19:47
DatabaseRowDefaultValues.php:66ReplyDoneDatabaseRowDefaultValues.php:66ReplyDoneDatabaseRowDefaultValues.php:79ReplyDone -
TYPO3com voted on patch set 4 V -1 09/08/18, 19:54 Completed build in 10m 51s on Sat, 8 Sep, 09:54 PM Test Summary: 3 of 36214 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27910
-
Guido Schmechel uploaded patch set 5 09/08/18, 20:21
-
TYPO3com voted on patch set 5 V +1 09/08/18, 20:32 Completed build in 10m 19s on Sat, 8 Sep, 10:32 PM Test Summary: 35866 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27911
-
Mathias Brodala voted on patch set 5 CR +1 09/10/18, 07:47
-
Oliver Hader commented on patch set 5 CR -1 09/10/18, 09:43
Thanks for your change, however I see some disadvantages of introducing this change: * label translation happens for the language of the current backend user, not for the actual language of the content/record (already pointed out by Susi in #typo3-cms-coredev channel) * `default` is used in DataHandler was well to provide default values for new records - the mentioned dependency on the current BackendUser might get problematic when importing data via CLI interface (and potentially lead to invalid results) In general I see this feature only related to the "view", but not related to "persistence". Therefore e.g. HTML placeholders could be used as "suggestion"... -
Christian Kuhn commented on patch set 5 CR -1 09/12/18, 09:04
good point olly. i'm with you at this point: it's probably not a good idea to set db defaults that depend on selected BE user language. This would be rather unexpected for many devs. -
Oliver Hader abandoned the change 09/12/18, 09:11
Feel free to reopen this change using an alternative approach that does not use `default`