Review main Merged

58197[BUGFIX] Use class name to mark upgrade wizards done

Helmut Hummel CR +2 V +2 Normal +32 −35 updated 12/13/18, 23:21

Commit message

To make the registry for done wizards consistent and stay backwards
compatible once all upgrade wizards are converted to use the
new interface, always store the class name of the wizard
instead of its identifier in the registry.

Additionally we now add checks for valid identifiers
to all API methods that receive one.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Susi Moog +1
  • Verified V +2
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1821

  1. Helmut Hummel uploaded patch set 1 09/06/18, 10:21

  2. Mathias Brodala commented on patch set 1 CR -1 09/06/18, 10:23

    What about migrating existing flags?

    UpgradeWizardsService.php:497

    A @throws must be added here.
  3. Helmut Hummel commented on patch set 1 09/06/18, 10:25

    UpgradeWizardsService.php:497 Reply

    is there a policy that this is a "must"? anyway, I will add it.
  4. Helmut Hummel wrote 09/06/18, 10:25

    Assignee added: Susi Moog <mail@susi-moog.de>
  5. Mathias Brodala commented on patch set 1 09/06/18, 10:26

    UpgradeWizardsService.php:497 Reply

  6. Mathias Brodala voted on patch set 1 CR 0 09/06/18, 10:26

  7. Mathias Brodala voted on patch set 1 CR -1 09/06/18, 10:27

  8. Helmut Hummel uploaded patch set 2 09/06/18, 10:27

  9. Helmut Hummel commented on patch set 1 09/06/18, 10:28

    UpgradeWizardsService.php:497 Reply

    Done
  10. TYPO3com voted on patch set 1 V +1 09/06/18, 10:31 Completed build in 09m 41s on Thu, 6 Sep, 12:31 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27813

  11. TYPO3com voted on patch set 2 V +1 09/06/18, 10:39 Completed build in 11m 59s on Thu, 6 Sep, 12:39 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27815

  12. Benni Mack wrote 09/06/18, 11:58

    Removed reviewer Benni Mack.
  13. Susi Moog commented on patch set 2 CR -1 09/13/18, 17:13

    on it, missing two places.
  14. Susi Moog uploaded patch set 3 09/13/18, 17:19

  15. TYPO3com voted on patch set 3 V +1 09/13/18, 17:28 Completed build in 09m 33s on Thu, 13 Sep, 07:28 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28050

  16. Susi Moog voted on patch set 3 V +1 CR +1 09/13/18, 17:48

  17. Wouter Wolters voted on patch set 3 CR +1 09/13/18, 18:28

  18. Anja Leichsenring voted on patch set 3 V +2 CR +2 09/13/18, 19:08

  19. Anja Leichsenring merged patch set 4 09/13/18, 19:08

  20. Helmut Hummel commented on patch set 4 09/14/18, 09:52

    thanks!
  21. Alexander Stehlik commented on patch set 4 12/13/18, 23:21