58197[BUGFIX] Use class name to mark upgrade wizards done
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Wouter Wolters +1
- Susi Moog +1
-
Verified V +2
- Anja Leichsenring +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1821
-
Helmut Hummel uploaded patch set 1 09/06/18, 10:21
-
Mathias Brodala commented on patch set 1 CR -1 09/06/18, 10:23
What about migrating existing flags?UpgradeWizardsService.php:497A @throws must be added here. -
Helmut Hummel commented on patch set 1 09/06/18, 10:25
UpgradeWizardsService.php:497Replyis there a policy that this is a "must"? anyway, I will add it. -
Helmut Hummel wrote 09/06/18, 10:25
Assignee added: Susi Moog <mail@susi-moog.de> -
Mathias Brodala commented on patch set 1 09/06/18, 10:26
UpgradeWizardsService.php:497ReplyNot a must apparently but good practice, see https://docs.typo3.org/typo3cms/CoreApiReference/CodingGuidelines/PhpArchitecture/WorkingWithExceptions.html#good-examples -
Mathias Brodala voted on patch set 1 CR 0 09/06/18, 10:26
-
Mathias Brodala voted on patch set 1 CR -1 09/06/18, 10:27
-
Helmut Hummel uploaded patch set 2 09/06/18, 10:27
-
Helmut Hummel commented on patch set 1 09/06/18, 10:28
UpgradeWizardsService.php:497ReplyDone -
TYPO3com voted on patch set 1 V +1 09/06/18, 10:31 Completed build in 09m 41s on Thu, 6 Sep, 12:31 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27813
-
TYPO3com voted on patch set 2 V +1 09/06/18, 10:39 Completed build in 11m 59s on Thu, 6 Sep, 12:39 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27815
-
Benni Mack wrote 09/06/18, 11:58
Removed reviewer Benni Mack. -
Susi Moog commented on patch set 2 CR -1 09/13/18, 17:13
on it, missing two places. -
Susi Moog uploaded patch set 3 09/13/18, 17:19
-
TYPO3com voted on patch set 3 V +1 09/13/18, 17:28 Completed build in 09m 33s on Thu, 13 Sep, 07:28 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28050
-
Susi Moog voted on patch set 3 V +1 CR +1 09/13/18, 17:48
-
Wouter Wolters voted on patch set 3 CR +1 09/13/18, 18:28
-
Anja Leichsenring voted on patch set 3 V +2 CR +2 09/13/18, 19:08
-
Anja Leichsenring merged patch set 4 09/13/18, 19:08
-
Helmut Hummel commented on patch set 4 09/14/18, 09:52
thanks! -
Alexander Stehlik commented on patch set 4 12/13/18, 23:21
Tiny follow-up in https://review.typo3.org/#/c/59142/