58199[TASK] Clean up UpgradeWizardsService API
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Georg Ringer +1
-
Verified V +2
- Anja Leichsenring +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1112
-
Helmut Hummel uploaded patch set 1 09/06/18, 10:44
-
Mathias Brodala commented on patch set 1 09/06/18, 10:46
IMO the current methods need to be properly deprecated. -
Helmut Hummel commented on patch set 1 09/06/18, 10:46
while this is strictly breaking, I personally would just change the method names to avoid deprecation overhead, as it is very unlikely that this API is already in use (or will be used before LTS release) -
Helmut Hummel commented on patch set 1 09/06/18, 10:49
@Mathias: the API was introduced a few days ago. How likely do you think it is, that code pops up using this API (in 9.4 context) until LTS release? -
TYPO3com voted on patch set 1 V +1 09/06/18, 10:54 Completed build in 09m 45s on Thu, 6 Sep, 12:54 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27817
-
Mathias Brodala commented on patch set 1 09/06/18, 10:58
> @Mathias: the API was introduced a few days ago. How likely do you > think it is, that code pops up using this API (in 9.4 context) > until LTS release? Honestly I didn't look up when this was added. In that case it's fine to change the API. -
Georg Ringer voted on patch set 1 V +1 CR +1 09/06/18, 11:03
-
Susi Moog commented on patch set 1 09/06/18, 11:49
Please be aware that the upgradeWizardsService is in fact the old API and the two methods touched here are the old methods... I don't consider the install tool in general as API unless otherwise declared, but wanted to ensure you are aware that these methods are a lot older than a few days. -
Benni Mack wrote 09/06/18, 11:57
Removed reviewer Benni Mack. -
Helmut Hummel commented on patch set 1 09/06/18, 12:21
> but wanted to ensure you are aware that these methods are a lot older than a few days ah, ok thanks. I did not carefully enough at the changes introduced recently. -
Anja Leichsenring voted on patch set 1 V +2 CR +2 09/07/18, 09:33
-
Anja Leichsenring merged patch set 2 09/07/18, 09:34