Review main Merged

58201[BUGFIX] Prevent crash in DatabaseIntegrityCheck

Christian Kuhn CR +2 V +2 Easy +16 −0 updated 09/07/18, 15:27

Commit message

If a relation field (select / group) does not exist in db for
whatever reason, System -> DB check -> Database relations
crashes.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Richard Haeser +1
    • Andreas Kienast +1
  • Verified V +2
    • Anja Leichsenring +2
    • Richard Haeser +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Christian Kuhn uploaded patch set 1 09/06/18, 13:59

  2. Christian Kuhn commented on patch set 1 09/06/18, 14:00

    verified that in v8, too. the v8 version is similar but needs the fix only in the lowlevel class. test: rename group_db_1 of tx_styleguide_elements_group to something else and see the module crash.
  3. TYPO3com voted on patch set 1 V +1 09/06/18, 14:09 Completed build in 09m 47s on Thu, 6 Sep, 04:09 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27821

  4. Georg Ringer commented on patch set 1 V -1 CR -1 09/06/18, 14:35

    If a field is required by tca and not there, this must not be caught silent but transformed into a readable information, *especially* in something like db integrity check
  5. Christian Kuhn uploaded patch set 2 09/06/18, 15:53

  6. TYPO3com voted on patch set 2 V +1 09/06/18, 16:03 Completed build in 09m 40s on Thu, 6 Sep, 06:03 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27824

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 09/06/18, 16:10

  8. Richard Haeser voted on patch set 2 V +1 CR +1 09/07/18, 06:00

  9. Anja Leichsenring voted on patch set 2 V +2 CR +2 09/07/18, 15:27

  10. Anja Leichsenring merged patch set 3 09/07/18, 15:27