Review main Merged

58213[BUGFIX] Fix fatal in ReportsModule with upgrade wizards

Christian Kuhn CR +2 V +2 Easy +15 −6 updated 09/07/18, 13:22

Commit message

With the new upgrade wizard API the InstallStatusReport
has to be adapted a bit to prevent a fatal calling
shouldRenderWizard() on wizards that don't have this
method.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Jan Helke +1
    • Roland Golla +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Roland Golla +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Christian Kuhn uploaded patch set 1 09/07/18, 12:42

  2. TYPO3com voted on patch set 1 V -1 09/07/18, 12:42 Completed build in 12s on Fri, 7 Sep, 02:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27847

  3. Christian Kuhn uploaded patch set 2 09/07/18, 12:44

  4. Susi Moog voted on patch set 2 CR +1 09/07/18, 12:46

  5. Daniel Goerz voted on patch set 2 V +1 CR +1 09/07/18, 12:48

  6. Andreas Kienast voted on patch set 2 CR +1 09/07/18, 12:52

  7. TYPO3com voted on patch set 2 V +1 09/07/18, 12:53 Completed build in 08m 58s on Fri, 7 Sep, 02:53 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27848

  8. Jan Helke voted on patch set 2 CR +1 09/07/18, 13:09

  9. Roland Golla commented on patch set 2 V +1 CR +1 09/07/18, 13:10

    This works for me and is fine
  10. Christian Kuhn voted on patch set 2 V +2 CR +2 09/07/18, 13:22

  11. Christian Kuhn merged patch set 3 09/07/18, 13:22