Review main Merged

58214[TASK] Protected methods in ReportController

Christian Kuhn CR +2 V +2 Normal +60 −8 updated 09/07/18, 17:05

Commit message

There are only two methods in the report controller, calling
them via call_user_function() does not make much sense.
The patch simplifies the dispatcher logic and sets the two
actions to protected.
Note this does not affect the extendability of the reports
module itself.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Roland Golla +1
    • Andreas Kienast +1
  • Verified V +2
    • Anja Leichsenring +2
    • Roland Golla +1
    • Andreas Kienast +1

Issues 2

Files 2

Review log 810

  1. Christian Kuhn uploaded patch set 1 09/07/18, 12:54

  2. TYPO3com voted on patch set 1 V +1 09/07/18, 13:04 Completed build in 10m 22s on Fri, 7 Sep, 03:04 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27849

  3. Roland Golla commented on patch set 1 V +1 CR +1 09/07/18, 14:12

    Looks clear and good for me
  4. Andreas Kienast commented on patch set 1 CR -1 09/07/18, 16:52

    Wrong ticket number
  5. Andreas Kienast updated the commit message in patch set 2 09/07/18, 16:54

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 09/07/18, 16:54

  7. Roland Golla voted on patch set 2 V +1 CR +1 09/07/18, 16:58

  8. Anja Leichsenring voted on patch set 2 V +2 CR +2 09/07/18, 16:59

  9. Anja Leichsenring merged patch set 3 09/07/18, 16:59

  10. TYPO3com voted on patch set 2 V +1 09/07/18, 17:05 Completed build in 10m 53s on Fri, 7 Sep, 07:05 PM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27877