Review main Merged

58215[TASK] Prevent notice in InstallStatusReport

Roland Golla CR +2 V +2 Easy +1 −1 updated 09/07/18, 20:36

Commit message

Add isset check before use is_array.
This will prevent a notice if the
array key does not exist.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Jörg Bösche +1
  • Verified V +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1418

  1. Roland Golla uploaded patch set 1 09/07/18, 13:26

  2. Andreas Kienast commented on patch set 1 09/07/18, 13:31

    InstallStatusReport.php:154 Unresolved

    I'd use if (is_array($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/install']['update'] ?? null)) {
  3. TYPO3com voted on patch set 1 V +1 09/07/18, 13:38 Completed build in 11m 52s on Fri, 7 Sep, 03:38 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27852

  4. Roland Golla rebased onto patch set 2 09/07/18, 13:41

  5. Roland Golla uploaded patch set 3 09/07/18, 13:48

  6. TYPO3com commented on patch set 2 09/07/18, 13:49 Completed build in 08m 32s on Fri, 7 Sep, 03:49 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27855

  7. TYPO3com voted on patch set 3 V +1 09/07/18, 13:58 Completed build in 09m 29s on Fri, 7 Sep, 03:58 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27857

  8. Andreas Kienast voted on patch set 3 CR +1 09/07/18, 15:38

  9. Georg Ringer voted on patch set 3 V +1 CR +1 09/07/18, 18:59

  10. Susi Moog commented on patch set 3 CR -1 09/07/18, 19:36

    InstallStatusReport.php:153

    shouldn't that ?? be inside the is_array?
  11. Andreas Kienast voted on patch set 3 CR -1 09/07/18, 19:37

  12. Anja Leichsenring uploaded patch set 4 09/07/18, 19:39

  13. Anja Leichsenring voted on patch set 4 V +1 CR +1 09/07/18, 19:47

  14. TYPO3com voted on patch set 4 V +1 09/07/18, 19:49 Completed build in 10m 12s on Fri, 7 Sep, 09:49 PM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27886

  15. Andreas Kienast voted on patch set 4 CR +1 09/07/18, 20:02

  16. Jörg Bösche voted on patch set 4 CR +1 09/07/18, 20:15

  17. Andreas Kienast voted on patch set 4 V +2 CR +2 09/07/18, 20:36

  18. Andreas Kienast merged patch set 5 09/07/18, 20:36