Review main Abandoned

58224[BUGFIX] Add translation pointer to slug uniqueness check

Andreas Kienast CR 0 V 0 Easy +26 −13 updated 09/20/18, 06:22

Commit message

To determine the uniqueness of a localized slug properly, the translation
pointer must be considered as well, as multiple localizations of a
specific language are possible on the same pid, altough the localizations
belong to different pages.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 67

  1. Andreas Kienast uploaded patch set 1 09/07/18, 19:59

  2. TYPO3com voted on patch set 1 V +1 09/07/18, 20:10 Completed build in 11m 10s on Fri, 7 Sep, 10:10 PM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27887

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 09/07/18, 20:11

  4. Oliver Hader commented on patch set 1 V -1 09/07/18, 20:43

    The patch would now allow the following: • http://site.com/en/my-slug/ (page uid 1) • http://site.com/de/my-slug/ (page uid 2, localization of uid 1) • http://site.com/en/other/ (page uid 3) • http://site.com/en/my-slug/ (page uid 4, localization of uid 2 - and duplicate slug)
  5. Andreas Kienast commented on patch set 1 09/15/18, 11:05

    How do we continue here? I have no clue how to fix the issue properly.
  6. Andreas Kienast abandoned the change 09/20/18, 05:43

    Wrong approach and no clue how to fix.
  7. Oliver Hader commented on patch set 1 09/20/18, 06:22