Review main Merged

58226[TASK] Protect FileListController

Christian Kuhn CR +2 V +2 Normal +127 −29 updated 09/09/18, 16:43

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 68

  1. Christian Kuhn uploaded patch set 1 09/08/18, 09:51

  2. Christian Kuhn updated the commit message in patch set 2 09/08/18, 09:51

  3. Christian Kuhn commented on patch set 1 09/08/18, 09:53

    BackendUserController.php:126

    note this is a drive-by change: it is the last public initializeView of a class that extends extbase action controller ... the parent method in ActionController is protected, too, so it does not have impact.
  4. TYPO3com voted on patch set 1 V +1 09/08/18, 10:00 Completed build in 08m 42s on Sat, 8 Sep, 12:00 PM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27897

  5. TYPO3com voted on patch set 2 V +1 09/08/18, 10:03 Completed build in 11m 43s on Sat, 8 Sep, 12:03 PM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27898

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 09/09/18, 16:29

  7. Wouter Wolters voted on patch set 2 V +2 CR +2 09/09/18, 16:43

  8. Wouter Wolters merged patch set 3 09/09/18, 16:43